Skip to content

Drop iOS 14 Support: Update UTType usages (#2) - #20898

Merged
kean merged 5 commits into
trunkfrom
task/ios-15-remove-more-uittype-apis
Jun 19, 2023
Merged

Drop iOS 14 Support: Update UTType usages (#2)#20898
kean merged 5 commits into
trunkfrom
task/ios-15-remove-more-uittype-apis

Conversation

@kean

@kean kean commented Jun 16, 2023

Copy link
Copy Markdown
Contributor

Related Issue #20860

Removes deprecated UTType APIs. Previous related PRs that update UTType API usages: #20887, #20866, #20889.

To test:

Most of the changes are covered by the new unit tests, but there were a couple of scenarios I tested manually, just to make sure:

GIF Badges

  • Open a Post / Post Settings / Set Featured Image
  • Verify that GIFs have badges

Filters Types

  • Open a Post
  • Add an Image block
  • Select “Other Apps”
  • Verify that is allows you to select only images
  • Repeat for other formats: video, audio

Regression Notes

  1. Potential unintended areas of impact: Media-related features
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual tests and unit tests
  3. What automated tests I added (or what prevented me from doing so): yes

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@kean kean added this to the Pending milestone Jun 16, 2023
@kean
kean requested a review from momo-ozawa June 16, 2023 22:42
@wpmobilebot

wpmobilebot commented Jun 16, 2023

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20898-2a53c18
Version22.6
Bundle IDcom.jetpack.alpha
Commit2a53c18
App Center Buildjetpack-installable-builds #5066
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

wpmobilebot commented Jun 16, 2023

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20898-2a53c18
Version22.6
Bundle IDorg.wordpress.alpha
Commit2a53c18
App Center BuildWPiOS - One-Offs #6040
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@momo-ozawa momo-ozawa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread WordPress/WordPressTest/MediaURLExporterTests.swift Outdated
Base automatically changed from task/ios-15-remove-deprecated-uibutton-apis to trunk June 19, 2023 12:22
Co-authored-by: Momo Ozawa <momo-ozawa@users.noreply.github.com>
@kean
kean enabled auto-merge June 19, 2023 13:42
@kean
kean merged commit de22f2a into trunk Jun 19, 2023
@kean
kean deleted the task/ios-15-remove-more-uittype-apis branch June 19, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants