Skip to content

Blaze Manage Campaigns: Preserve image aspect for campaign thumbnail#21296

Merged
momo-ozawa merged 1 commit into
release/23.0from
fix/blaze-campaign-image-aspect
Aug 11, 2023
Merged

Blaze Manage Campaigns: Preserve image aspect for campaign thumbnail#21296
momo-ozawa merged 1 commit into
release/23.0from
fix/blaze-campaign-image-aspect

Conversation

@momo-ozawa
Copy link
Copy Markdown
Contributor

Description

  • Sets content mode to scaleAspectFill to preserve image aspect
Before After

To test

  1. Switch to a site with Blaze campaigns
  2. ✅ Verify that the thumbnail image in the dashboard card preserves the image aspect
  3. Navigate to the Blaze campaigns list screen (Dashboard card > tap title)
  4. ✅ Verify that the thumbnail image preseves the image aspect

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@momo-ozawa momo-ozawa added this to the 23.0 ❄️ milestone Aug 10, 2023
@momo-ozawa momo-ozawa requested a review from kean August 10, 2023 14:16
@momo-ozawa momo-ozawa self-assigned this Aug 10, 2023
@peril-wordpress-mobile
Copy link
Copy Markdown

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@momo-ozawa
Copy link
Copy Markdown
Contributor Author

FYI @mokagio 🙇‍♀️

@wpmobilebot
Copy link
Copy Markdown
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21296-71b2537
Version23.0
Bundle IDcom.jetpack.alpha
Commit71b2537
App Center Buildjetpack-installable-builds #5709
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21296-71b2537
Version23.0
Bundle IDorg.wordpress.alpha
Commit71b2537
App Center BuildWPiOS - One-Offs #6671
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@momo-ozawa momo-ozawa changed the base branch from trunk to release/23.0 August 10, 2023 15:46
@kean
Copy link
Copy Markdown
Contributor

kean commented Aug 10, 2023

😨

@momo-ozawa momo-ozawa merged commit 4455311 into release/23.0 Aug 11, 2023
@momo-ozawa momo-ozawa deleted the fix/blaze-campaign-image-aspect branch August 11, 2023 09:48
@mokagio mokagio mentioned this pull request Aug 14, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants