Skip to content

Lock Screen Widgets: Add more configurations - #21495

Merged
staskus merged 7 commits into
trunkfrom
task/21494-lock-screen-widgets-more-configurations
Sep 7, 2023
Merged

Lock Screen Widgets: Add more configurations#21495
staskus merged 7 commits into
trunkfrom
task/21494-lock-screen-widgets-more-configurations

Conversation

@staskus

@staskus staskus commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

Fixes #21494

Added:

To test

  1. Enable lockScreenWidget feature flag in FeatureFlag.swift
  2. Open Jetpack
  3. Log into account
  4. Go to lock screen, long press, customize, tap on widget area, select Jetpack app
  5. Scroll through widgets
  6. Confirm new widget configuration exists
  7. Confirm their numbers match Stats
  8. Confirm tapping on Today widget opens "Day" view
  9. Confirm tapping on All time widget opens "Insights"view

Regression Notes

  1. Potential unintended areas of impact

None

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

None

  1. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

Video

Simulator.Screen.Recording.-.iPhone.14.-.2023-09-06.at.17.43.12.mp4

@wpmobilebot

wpmobilebot commented Sep 5, 2023

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21495-8a73288
Version23.2
Bundle IDcom.jetpack.alpha
Commit8a73288
App Center Buildjetpack-installable-builds #6015
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@staskus
staskus force-pushed the task/21494-lock-screen-widgets-more-configurations branch from 413e1fd to 984d8df Compare September 6, 2023 12:30
@wpmobilebot

wpmobilebot commented Sep 6, 2023

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21495-8a73288
Version23.2
Bundle IDorg.wordpress.alpha
Commit8a73288
App Center BuildWPiOS - One-Offs #6973
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Base automatically changed from task/21489-lock-screen-widgets-two-field to trunk September 6, 2023 14:25
@staskus
staskus force-pushed the task/21494-lock-screen-widgets-more-configurations branch from 984d8df to 54e91ff Compare September 6, 2023 14:43
@staskus
staskus marked this pull request as ready for review September 6, 2023 14:46
@staskus staskus added this to the 23.3 milestone Sep 6, 2023
@staskus
staskus requested a review from guarani September 6, 2023 14:47

@guarani guarani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great, I checked the values against WP.com and all match.

@staskus
staskus enabled auto-merge (squash) September 7, 2023 10:19
@staskus
staskus disabled auto-merge September 7, 2023 10:20
@staskus
staskus enabled auto-merge (squash) September 7, 2023 10:20
@staskus
staskus merged commit 02012e9 into trunk Sep 7, 2023
@staskus
staskus deleted the task/21494-lock-screen-widgets-more-configurations branch September 7, 2023 11:13
@staskus staskus mentioned this pull request Sep 8, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lock Screen Widgets: Add more widget configurations

3 participants