Skip to content

Lock Screen Widgets: Refresh widgets when app state changes - #21518

Merged
staskus merged 4 commits into
trunkfrom
task/21515-lock-screen-widgets-refresh-widgets-when-app-state-changes
Sep 8, 2023
Merged

Lock Screen Widgets: Refresh widgets when app state changes#21518
staskus merged 4 commits into
trunkfrom
task/21515-lock-screen-widgets-refresh-widgets-when-app-state-changes

Conversation

@staskus

@staskus staskus commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Fixes #21515

Different widgets need to be explicitly reloaded using reloadTimelines(ofKind..) method

To test:

Before testing

  1. Open Jetpack
  2. Log into the account
  3. Enable Lock Screen Widget feature flag
  4. Open Lock screen, long tap, tap Customize, select Widget area
  5. Tap on Jetpack
  6. Add different types of widgets

Logged out

  1. Complete "before testing" steps
  2. Go back to the app
  3. Logout
  4. Confirm widgets show "Please login" option

No site

  1. Complete "before testing" steps
  2. Go back to the app
  3. Logout
  4. Log into the account with no sites
  5. Confirm widgets show "No site" message

Regression Notes

  1. Potential unintended areas of impact

None

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

None

  1. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • [] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:
Does not apply

@peril-wordpress-mobile

Copy link
Copy Markdown
Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@staskus staskus added this to the 23.3 milestone Sep 7, 2023
@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21518-fc2cbce
Version23.2
Bundle IDorg.wordpress.alpha
Commitfc2cbce
App Center BuildWPiOS - One-Offs #6977
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21518-fc2cbce
Version23.2
Bundle IDcom.jetpack.alpha
Commitfc2cbce
App Center Buildjetpack-installable-builds #6019
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@guarani guarani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the scenarios (logged out & no sites) and the widgets showed the appropriate messages. Thanks @staskus!

@staskus
staskus merged commit e9f014e into trunk Sep 8, 2023
@staskus
staskus deleted the task/21515-lock-screen-widgets-refresh-widgets-when-app-state-changes branch September 8, 2023 06:09
@staskus staskus mentioned this pull request Sep 8, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lock Screen Widgets: Refresh widgets when app state changes

3 participants