Skip to content

Lock Screen Widgets: VoiceOver improvements - #21534

Merged
staskus merged 1 commit into
trunkfrom
task/lock-screen-widgets-voiceover
Sep 11, 2023
Merged

Lock Screen Widgets: VoiceOver improvements#21534
staskus merged 1 commit into
trunkfrom
task/lock-screen-widgets-voiceover

Conversation

@staskus

@staskus staskus commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

Grouping elements together so the widget information would be read out all at once. Otherwise, the elements on the widget are too small to properly interact with.

VoiceOver.Grouping.mov

To test:

  1. Enable lockScreenWidget feature flag in FeatureFlag.swift
  2. Open Jetpack, log into wp.com account
  3. Add Lock Screen widgets
  4. Enable voice over
  5. Confirm that the information is read out clearly

Regression Notes

  1. Potential unintended areas of impact

None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@staskus staskus added this to the 23.3 milestone Sep 8, 2023
@staskus
staskus requested a review from guarani September 8, 2023 12:46
@staskus staskus mentioned this pull request Sep 8, 2023
4 tasks
@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21534-7c28ebf
Version23.2
Bundle IDorg.wordpress.alpha
Commit7c28ebf
App Center BuildWPiOS - One-Offs #6996
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21534-7c28ebf
Version23.2
Bundle IDcom.jetpack.alpha
Commit7c28ebf
App Center Buildjetpack-installable-builds #6039
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@guarani guarani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that a VoiceOver tap now selects the whole widget and reads its contents in one go.
Thanks @staskus!

@staskus
staskus merged commit 74c91bb into trunk Sep 11, 2023
@staskus
staskus deleted the task/lock-screen-widgets-voiceover branch September 11, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants