[UI Tests] - Fix failing testAddMediaBlocks() test

[jostnes]

Description

Test failed because of a UI change when adding media blocks via URL. In the updated design, the test no longer needs to tap on a specific button. A swipe-down gesture or a tap anywhere on the screen should now dismiss the view. The fix for this is to use swipeDown() instead. I also removed the button and getter since it's no longer referenced anywhere on the screen.

The swipeDown() method didn't work when the test ran in CI. I created tapTopOfScreen() to tap a specific coordinate on the screen to dismiss the view instead. However, this also doesn't work on iPhone in CI for reasons I don't understand yet. So, the test is only set to run on iPad until there's a better solution.

Testing

CI should be 🟢

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr21582-09d9f20
	Version	23.2
	Bundle ID	org.wordpress.alpha
	Commit	09d9f20
	App Center Build	WPiOS - One-Offs #7102

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr21582-09d9f20
	Version	23.2
	Bundle ID	com.jetpack.alpha
	Commit	09d9f20
	App Center Build	jetpack-installable-builds #6146

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[fluiddot]

This problem only affects the Video and Audio blocks due to inserting media via URL. So I'm wondering if we could only skip those. Maybe we could have two different UI tests depending on the device:

1. iPhone: Test Gallery block
2. iPad: Test Gallery, Video, and Audio blocks

WDYT?

[jostnes]

I wouldn't recommend breaking it into two tests, especially if the blocks should behave the same on both iPhone and iPad, I also believe that this should be a temporary and not a permanent skip.

I understand the concern around test coverage, though. So to handle this, I moved the skip after adding the image for the iPhone test so the test would still test up to add image, if the image fails to load, the test would still fail. I made the changes in 09d9f20

wdyt?

[fluiddot]

I wouldn't recommend breaking it into two tests, especially if the blocks should behave the same on both iPhone and iPad, I also believe that this should be a temporary and not a permanent skip.

Yeah, good point.

I understand the concern around test coverage, though. So to handle this, I moved the skip after adding the image for the iPhone test so the test would still test up to add image, if the image fails to load, the test would still fail. I made the changes in 09d9f20

Great idea, I'll take a look.

[fluiddot]

LGTM 🎊 ! Thanks @jostnes for addressing the UI test failure 🙇 !