Plans in Site Creation: Use domain_name returned from Plan Selection view

[staskus]

Fixes #21787

When users select a paid domain, they can still opt-in for a free wordpress.com subdomain in the plan selection view.

When a domain is selected, it is returned through domain_name parameter.

Use this domain when creating siteURLString instead of the one selected in the domain selection view.

To test:

Before testing: Enable Plans in Site Creation feature flag

4 cases need to be tested and confirmed to be working properly:

• Select a paid domain, then select a free plan. Confirm that the domain shown in the pop-up matches the one that the site was created with
• Select a paid domain, then select a paid plan. Confirm that checkout is opened and that the domain selected in the domain selection matches the one that appears in the checkout view
• Select a free domain, then select a free plan. Confirm that the site was created with the domain that was selected in the domain selection view
• Select a free domain, then select a paid plan. Confirm that the site was created with the domain that was selected in the domain selection view

Regression Notes

1. Potential unintended areas of impact

The change in siteURLString could potentially break existing functionality. Need to retest all the scenarios to make sure everything works as expected.

2. What I did to test those areas of impact (or what existing automated tests I relied on)

Updated unit tests

3. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr21790-ddc1699
	Version	23.5
	Bundle ID	org.wordpress.alpha
	Commit	ddc1699
	App Center Build	WPiOS - One-Offs #7429

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr21790-ddc1699
	Version	23.5
	Bundle ID	com.jetpack.alpha
	Commit	ddc1699
	App Center Build	jetpack-installable-builds #6458

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[guarani]

I compared the changes here to Automattic/wp-calypso#83045 and it looks like it will work 👍 Will review once the Calypso PR is merged.

[guarani]

Tested again now that the Calypso changes are deployed and this is working fine 👍

• ✅ Paid domain + Free plan
• ✅ Paid domain + Paid plan
• ✅ Free domain + Free plan
• ✅ Free domain + Paid plan