Fix an issue with scheduling of posts not working on iOS 17 with Xcode 15 - #22012
Merged
Conversation
kean
force-pushed
the
fix/scheduling-not-working
branch
from
November 9, 2023 13:03
d5f1479 to
4ae88ed
Compare
kean
force-pushed
the
fix/scheduling-not-working
branch
from
November 9, 2023 13:06
4ae88ed to
f6f066f
Compare
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22012-97a612f | |
| Version | 23.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 97a612f | |
| App Center Build | WPiOS - One-Offs #7884 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22012-97a612f | |
| Version | 23.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 97a612f | |
| App Center Build | jetpack-installable-builds #6908 |
momo-ozawa
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #21649
I removed
PartScreenPresentationControllerbecause it was used only in one place, which is a good thing because it means no other parts of the app has this regression. There is a way to implement the same (or better) behavior using the new-ish native UISheetPresentationController. But I decided to err on the side of simplicity and show it as a simple default model screen.To test:
Simulator.Screen.Recording.-.iPhone.15.-.2023-11-09.at.07.59.16.mp4
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: