Custom analyticsSource for the checkout web view when presented from All Domains flow - #22034
Conversation
fbec234 to
a85b1b4
Compare
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22034-cc4be24 | |
| Version | 23.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | cc4be24 | |
| App Center Build | WPiOS - One-Offs #7839 |
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22034-cc4be24 | |
| Version | 23.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | cc4be24 | |
| App Center Build | jetpack-installable-builds #6865 |
|
I'm going to bump this to the next release because we'll be code freezing 23.7 today and this hasn't been approved yet. If this cannot wait two weeks and it's important that it makes it into this release, let me know and we'll organize a new beta once ready. |
hassaanelgarem
left a comment
There was a problem hiding this comment.
Works as described 🚀
While you're at it, can you handle the TODO in RegisterDomainCoordinator.swift:L197? 🙏
Resolved in cc4be24. N.B. I rebased this branch to |
a74603f to
cc4be24
Compare
@mokagio We would like this PR to be included in the version 23.7 but it doesn't require a new beta deployment as it doesn't add any new user-facing changes. |


Closes #21996
Description
This PR changes the
analyticsSourcevalue for the checkout web view when presented from the All Domains flow.Test Instructions
Domain Only
Me > All Domainsthen tap + button.webkitview_displayed <source: all_domains>to be logged in the console.Existing Site
Me > All Domainsthen tap + button.webkitview_displayed <source: all_domains>to be logged in the console.Regression
My Site > Domains.webkitview_displayed <source: domains_register>to be logged in the console.Regression Notes
Potential unintended areas of impact
The value of
analyticsSourceshould bedomains_registerwhen presented from theMy Site > Domainsflow.What I did to test those areas of impact (or what existing automated tests I relied on)
None.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.