Skip to content

Custom analyticsSource for the checkout web view when presented from All Domains flow - #22034

Merged
mokagio merged 3 commits into
release/23.7from
task/21996-web-flow-analytics-source
Nov 14, 2023
Merged

Custom analyticsSource for the checkout web view when presented from All Domains flow#22034
mokagio merged 3 commits into
release/23.7from
task/21996-web-flow-analytics-source

Conversation

@salimbraksa

@salimbraksa salimbraksa commented Nov 11, 2023

Copy link
Copy Markdown
Contributor

Closes #21996

Description

This PR changes the analyticsSource value for the checkout web view when presented from the All Domains flow.

Test Instructions

Domain Only

  1. Navigate to Me > All Domains then tap + button.
  2. Search for a domain then select it.
  3. Tap "Just buy a domain"
  4. Expect the event webkitview_displayed <source: all_domains> to be logged in the console.

Existing Site

  1. Navigate to Me > All Domains then tap + button.
  2. Search for a domain then select it.
  3. Tap "Existing wordpress.com site"
  4. Select a site.
  5. Expect the event webkitview_displayed <source: all_domains> to be logged in the console.

Regression

  1. Navigate to My Site > Domains.
  2. Search for a domain then select it.
  3. Expect the event webkitview_displayed <source: domains_register> to be logged in the console.

Regression Notes

  1. Potential unintended areas of impact
    The value of analyticsSource should be domains_register when presented from the My Site > Domains flow.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    None.

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@salimbraksa salimbraksa self-assigned this Nov 11, 2023
@salimbraksa salimbraksa added this to the 23.7 milestone Nov 11, 2023
@salimbraksa
salimbraksa force-pushed the task/21996-web-flow-analytics-source branch from fbec234 to a85b1b4 Compare November 11, 2023 15:04
@wpmobilebot

wpmobilebot commented Nov 11, 2023

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22034-cc4be24
Version23.7
Bundle IDorg.wordpress.alpha
Commitcc4be24
App Center BuildWPiOS - One-Offs #7839
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

wpmobilebot commented Nov 11, 2023

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22034-cc4be24
Version23.7
Bundle IDcom.jetpack.alpha
Commitcc4be24
App Center Buildjetpack-installable-builds #6865
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@salimbraksa
salimbraksa marked this pull request as ready for review November 12, 2023 23:14
@mokagio

mokagio commented Nov 13, 2023

Copy link
Copy Markdown
Contributor

I'm going to bump this to the next release because we'll be code freezing 23.7 today and this hasn't been approved yet.

If this cannot wait two weeks and it's important that it makes it into this release, let me know and we'll organize a new beta once ready.

@mokagio mokagio modified the milestones: 23.7, 23.8 Nov 13, 2023

@hassaanelgarem hassaanelgarem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 🚀

While you're at it, can you handle the TODO in RegisterDomainCoordinator.swift:L197? 🙏

@salimbraksa

salimbraksa commented Nov 13, 2023

Copy link
Copy Markdown
Contributor Author

While you're at it, can you handle the TODO in RegisterDomainCoordinator.swift:L197? 🙏

Resolved in cc4be24.

N.B. I rebased this branch to release/23.7, so you might see old commits re-appearing in the activity feed again.

@salimbraksa
salimbraksa changed the base branch from trunk to release/23.7 November 13, 2023 20:38
@salimbraksa
salimbraksa force-pushed the task/21996-web-flow-analytics-source branch from a74603f to cc4be24 Compare November 13, 2023 20:39
@salimbraksa

Copy link
Copy Markdown
Contributor Author

If this cannot wait two weeks and it's important that it makes it into this release, let me know and we'll organize a new beta once ready.

@mokagio We would like this PR to be included in the version 23.7 but it doesn't require a new beta deployment as it doesn't add any new user-facing changes.

@mokagio
mokagio merged commit 32251b0 into release/23.7 Nov 14, 2023
@mokagio
mokagio deleted the task/21996-web-flow-analytics-source branch November 14, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update track events within the web flow

4 participants