In App Feedback Prompt Groundwork by salimbraksa · Pull Request #22050 · wordpress-mobile/WordPress-iOS

salimbraksa · 2023-11-16T10:56:04Z

Description

This PR makes changes to the existing AppRatingsUtility type. This utility object is responsible for deciding when the App Ratings UI should be shown. The changes include:

Remove the existing App Ratings UX from the Notifications screen.
Remove the old remote feature flag mechanism this object was using.
Raise the required action count for the App Ratings Prompt to display to 20.
The following actions increment the action count:
- ~~User visits the Notifications screens and has unread notifications.~~ User taps on unread notification ( see this comment )
- User publishes a post.
- User reads a post.
- User views stats.

Test Instructions

Same as #22052

Notes

Remove then DO NOT MERGE label when the following PR is approved:

In-App Feedback Prompt UI #22052

Regression Notes

Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
None.
What automated tests I added (or what prevented me from doing so)
None.

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

wpmobilebot · 2023-11-16T11:17:37Z

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22050-dc57c78
	Version	24.0
	Bundle ID	org.wordpress.alpha
	Commit	`dc57c78`
	App Center Build	WPiOS - One-Offs #8497

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot · 2023-11-16T11:22:52Z

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22050-dc57c78
	Version	24.0
	Bundle ID	com.jetpack.alpha
	Commit	`dc57c78`
	App Center Build	jetpack-installable-builds #7519

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

mokagio · 2024-01-08T10:26:35Z

I've been going trough PRs to update them via git merge trunk to include #22270 and run on the new Apple Silicon CI with Xcode 15.1.

I did not work on this one because it already developed merge conflicts with trunk so a merge and work by the author is required regardless.

salimbraksa · 2024-01-09T12:19:07Z

        let utility = AppRatingUtility.shared
-        utility.register(section: "notifications", significantEventCount: 5)
-        utility.systemWideSignificantEventCountRequiredForPrompt = 10
+        utility.systemWideSignificantEventCountRequiredForPrompt = 20


This means, that at least 20 actions should be performed for the App Ratings Prompt to appear.

The count is increased using this method:

AppRatingUtility.shared.incrementSignificantEvent()

salimbraksa · 2024-01-09T12:21:23Z

-    /// This checks if we've disabled app review prompts for a feature or at a
-    /// global level
-    ///
-    @objc func checkIfAppReviewPromptsHaveBeenDisabled(success: (() -> Void)?, failure: (() -> Void)?) {


This is an old remote feature flag mechanism. It is replaced with the new one.

salimbraksa · 2024-01-09T12:23:49Z

    func register(section: String, significantEventCount count: Int) {
-        sections[section] = Section(significantEventCount: count, enabled: true)
+        sections[section] = Section(significantEventCount: count)
    }


The enabled property was never set to false. It was always true.

…ion sites with existing plan

…ler overlays presentation

alpavanoglu

LGTM. I'll test it again though when we merge the child PR into this one.

peril-wordpress-mobile · 2024-01-18T16:03:22Z

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

dangermattic · 2024-01-18T16:07:29Z

	2 Warnings
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	This PR is assigned to the milestone 24.1. This milestone is due in less than 4 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

salimbraksa self-assigned this Nov 16, 2023

salimbraksa added [Type] Task In-App Rating Prompt labels Nov 16, 2023

salimbraksa requested a review from hassaanelgarem November 16, 2023 10:58

salimbraksa marked this pull request as ready for review November 16, 2023 10:58

hassaanelgarem removed their request for review December 13, 2023 23:55

hassaanelgarem self-assigned this Dec 13, 2023

hassaanelgarem marked this pull request as draft December 13, 2023 23:55

salimbraksa commented Jan 9, 2024

View reviewed changes

salimbraksa requested a review from alpavanoglu January 9, 2024 12:31

salimbraksa force-pushed the task/in-app-feedback branch from 02959d0 to a65af62 Compare January 9, 2024 12:31

salimbraksa and others added 12 commits January 9, 2024 13:36

Fix an issue where the All Domains flow wasn't taking into considerat…

6486e4c

…ion sites with existing plan

Implement groundwork for the in-app feedback feature

10f1830

Update: add feature flag for in-app rating

a5db339

Update: Remove outdated code in AppRatingUtility

c586ecf

Update: remove logic for notifications rating flow

08be479

Update: track viewing unread notifications as significant event

da5f9cd

Update: track post/page publish significant event

26308a8

Update: track viewing stats as significant event

fc3e14d

Update: track viewing reader detail as significant event

6546cc7

Update: change significant events threshold to 20

d6fec8e

Remove unit tests not needed anymore

82c5868

Update: fix failing tests

6a98364

salimbraksa force-pushed the task/in-app-feedback branch from a65af62 to 6a98364 Compare January 9, 2024 12:36

Revert unwanted changes

4faad52

Revert unwanted changes

5129319

salimbraksa changed the title ~~Implement groundwork for the in-app feedback feature~~ In App Feecdback Prompt Groundwork Jan 9, 2024

salimbraksa mentioned this pull request Jan 9, 2024

In-App Feedback Prompt UI #22052

Merged

13 tasks

salimbraksa changed the title ~~In App Feecdback Prompt Groundwork~~ In App Feedback Prompt Groundwork Jan 9, 2024

salimbraksa added 8 commits January 10, 2024 14:34

Move in-app feedback presentation to My Site view controller

c7be962

Implement an object responsible for coordinating My Site view control…

41fa80f

…ler overlays presentation

Rename showPromptIfNeeded to presentIfNeeded

d742309

Revert unwanted changes

05e3f2d

Replace the UserDefaults type to UserPersistentRepositoryReader

cb10a4a

Track appReviewsCanceledFeedbackScreen in viewDidDisappear

a9dd8ab

Add localized strings comments

44c4b3f

Fix failing unit test

9b8db01

salimbraksa modified the milestones: Pending, 24.1 Jan 17, 2024

alpavanoglu reviewed Jan 17, 2024

View reviewed changes

salimbraksa and others added 3 commits January 18, 2024 14:53

Convert InAppFeedbackCoordinator to class

35a048e

Revert Podfile.lock changes

46e2143

In-App Feedback Prompt UI (#22052)

4dc2a78

Sync with trunk and fix conflicts

cb2286a

salimbraksa requested a review from alpavanoglu January 18, 2024 16:05

salimbraksa removed the [Status] DO NOT MERGE label Jan 18, 2024

Set default inAppFeedback remote feature flag to false

e9085cf

alpavanoglu approved these changes Jan 18, 2024

View reviewed changes

salimbraksa added 3 commits January 19, 2024 19:19

Sync with trunk and fix conflicts

18b8994

Update RELEASE-NOTES

d844c28

Update Compliance Popover tests

dc57c78

salimbraksa merged commit 09c51c9 into trunk Jan 19, 2024

salimbraksa deleted the task/in-app-feedback branch January 19, 2024 19:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

In App Feedback Prompt Groundwork - #22050

In App Feedback Prompt Groundwork#22050
salimbraksa merged 42 commits into
trunkfrom
task/in-app-feedback

salimbraksa commented Nov 16, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Nov 16, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Nov 16, 2023 •

edited

Loading

Uh oh!

mokagio commented Jan 8, 2024

Uh oh!

salimbraksa Jan 9, 2024 •

edited

Loading

Uh oh!

salimbraksa Jan 9, 2024

Uh oh!

salimbraksa Jan 9, 2024

Uh oh!

alpavanoglu left a comment

Uh oh!

peril-wordpress-mobile Bot commented Jan 18, 2024 •

edited

Loading

Uh oh!

dangermattic commented Jan 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

salimbraksa commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Instructions

Notes

Regression Notes

PR submission checklist:

Uh oh!

wpmobilebot commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mokagio commented Jan 8, 2024

Uh oh!

salimbraksa Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

salimbraksa Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

salimbraksa Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

alpavanoglu left a comment

Choose a reason for hiding this comment

Uh oh!

peril-wordpress-mobile Bot commented Jan 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangermattic commented Jan 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

salimbraksa commented Nov 16, 2023 •

edited

Loading

wpmobilebot commented Nov 16, 2023 •

edited

Loading

wpmobilebot commented Nov 16, 2023 •

edited

Loading

salimbraksa Jan 9, 2024 •

edited

Loading

peril-wordpress-mobile Bot commented Jan 18, 2024 •

edited

Loading