Skip to content

Update WordPressKit to the latest version - #22233

Closed
crazytonyli wants to merge 2 commits into
trunkfrom
update-wordpresskit-9.0.1
Closed

Update WordPressKit to the latest version#22233
crazytonyli wants to merge 2 commits into
trunkfrom
update-wordpresskit-9.0.1

Conversation

@crazytonyli

Copy link
Copy Markdown
Contributor

Include a bug fix in wordpress-mobile/WordPressKit-iOS#662, where a Swift type name may show up in an error alert during login.

Regression Notes

N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist: N/A

@crazytonyli crazytonyli added this to the 24.0 milestone Dec 15, 2023
@crazytonyli
crazytonyli requested a review from a team December 15, 2023 05:09
@crazytonyli crazytonyli self-assigned this Dec 15, 2023
@wpmobilebot

wpmobilebot commented Dec 15, 2023

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22233-ebe761f
Version23.9
Bundle IDorg.wordpress.alpha
Commitebe761f
App Center BuildWPiOS - One-Offs #8339
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

wpmobilebot commented Dec 15, 2023

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22233-ebe761f
Version23.9
Bundle IDcom.jetpack.alpha
Commitebe761f
App Center Buildjetpack-installable-builds #7362
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@peril-wordpress-mobile

Copy link
Copy Markdown
Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot

Copy link
Copy Markdown
Contributor
1 Warning
⚠️ This PR is assigned to the milestone 24.0. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@mokagio

mokagio commented Jan 7, 2024

Copy link
Copy Markdown
Contributor

Looking at the diff after I merged trunk into this, I realized that #21904 already brought the 9.0.1 changes into trunk by using a WordPressKit commit after the one this PR points to:

image

Closing.

@mokagio mokagio closed this Jan 7, 2024
@mokagio
mokagio deleted the update-wordpresskit-9.0.1 branch January 7, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants