Skip to content

Update WordPressKit to address #22891 - #22900

Merged
mokagio merged 2 commits into
release/24.5from
mokagio/wordpresskit-update
Mar 27, 2024
Merged

Update WordPressKit to address #22891#22900
mokagio merged 2 commits into
release/24.5from
mokagio/wordpresskit-update

Conversation

@mokagio

@mokagio mokagio commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

What it says on the title 😅

As @crazytonyli explained in wordpress-mobile/WordPressKit-iOS#767, it challenging to find a plugin to reproduce the crash. But the code change is unit tested at the library level. 👏 Tony.


Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Mar 26, 2024
@mokagio mokagio added this to the 24.5 ❄️ milestone Mar 26, 2024
@mokagio
mokagio requested review from crazytonyli and staskus March 26, 2024 09:24
@dangermattic

dangermattic commented Mar 26, 2024

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 24.5 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot

wpmobilebot commented Mar 26, 2024

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22900-5d6a5f0
Version24.5
Bundle IDorg.wordpress.alpha
Commit5d6a5f0
App Center BuildWPiOS - One-Offs #9276
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

wpmobilebot commented Mar 26, 2024

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22900-5d6a5f0
Version24.5
Bundle IDcom.jetpack.alpha
Commit5d6a5f0
App Center Buildjetpack-installable-builds #8320
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean mentioned this pull request Mar 26, 2024
15 tasks

@crazytonyli crazytonyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for publishing the library releases and updating them here!

@mokagio
mokagio enabled auto-merge March 27, 2024 01:48
@mokagio
mokagio merged commit a3c3451 into release/24.5 Mar 27, 2024
@mokagio
mokagio deleted the mokagio/wordpresskit-update branch March 27, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants