Offline Mode: Remove secondary actions from the editor

[kean]

• Update the primary action for drafts to always be “Publish” (to match web and Android)
• Remove secondary actions (“Save as Draft”) – you tap back now and it’s offline-first

This eliminates the scenario where you tap "Update" and need to force the sync engine to save the changes synchronously, so we no longer have to worry about it.

To test:

• Verify that both new and existing drafts have a primary action "Publish" and no secondary action

The secondary action used to be here:

Regression Notes

1. Potential unintended areas of impact: Post Editor
2. What I did to test those areas of impact (or what existing automated tests I relied on): n/a
3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22913-be54822
	Version	24.5
	Bundle ID	org.wordpress.alpha
	Commit	be54822
	App Center Build	WPiOS - One-Offs #9340

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22913-be54822
	Version	24.5
	Bundle ID	com.jetpack.alpha
	Commit	be54822
	App Center Build	jetpack-installable-builds #8384

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[kean]

Found an issue where sometimes "Publish" for existing posts does not seem to be available.
Update: fixed.

[kean]

These tests were covering what would be typically considered "configuration": the logic in the unit tests is as complex (or simple) as in the code itself, so I decided to remove these.

[momo-ozawa]

Works as described, but I found an issue accessing drafts as a contributor

[momo-ozawa]

If I open a draft as a contributor, the app crashes at this assertion failure due to the post editor action being .save

[momo-ozawa]

I think there are a few issues with the contributor role, which I think is related to the sync engine changes:

• If I create a new draft as a contributor, the post list cell activity indicator never disappears. When I re-open the editor, then tap the back button without making any changes, the app crashes because it fails the isOriginal() assertion for isNewDraft
• As mentioned above, if I open a draft that's been submitted for review, the app crashes because the post editor action is .save (doesn't matter if you're logged in as a contributor or an admin)

[kean]

I'll cover the contributor role and pending posts in a separate PR and according to the amend to the spec 👍
Working on it right now.

[kean]

Fixed in the following PR: #22949