Skip to content

Remove iAd (Apple Search Ads) attribution#23365

Merged
jkmassel merged 1 commit into
trunkfrom
remove/search-ads-attribution
Jun 18, 2024
Merged

Remove iAd (Apple Search Ads) attribution#23365
jkmassel merged 1 commit into
trunkfrom
remove/search-ads-attribution

Conversation

@jkmassel

@jkmassel jkmassel commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

We're not purchasing ads for the app, and this code is deprecated. Let's remove it for now.

Includes some Xcode project cleanup noise

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@jkmassel jkmassel self-assigned this Jun 17, 2024
@jkmassel jkmassel added this to the 25.2 milestone Jun 17, 2024
@wpmobilebot

wpmobilebot commented Jun 17, 2024

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23365-2a61e2d
Version25.1
Bundle IDorg.wordpress.alpha
Commit2a61e2d
App Center BuildWPiOS - One-Offs #10190
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

wpmobilebot commented Jun 17, 2024

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23365-2a61e2d
Version25.1
Bundle IDcom.jetpack.alpha
Commit2a61e2d
App Center Buildjetpack-installable-builds #9239
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@jkmassel
jkmassel marked this pull request as ready for review June 18, 2024 19:25
@jkmassel
jkmassel requested a review from kean June 18, 2024 19:25
@kean

kean commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

LGTM.

It seems that this API is not only deprecated but is also no longer working:

After February 7, 2023, all requests made to the Apple Search Ads iAd Attribution API will return with a value of "iad-attribution" = false, or errors. See ADClient/requestAttributionDetails(_:).

Source: https://developer.apple.com/documentation/iad/setting-up-apple-search-ads-attribution

There was a relatively recent search ad-campaign, but I'm not sure if it used the attribution info. It's reasonable to assume that if we run one again, we'll need to add a new attribution tracking code.

Comment thread WordPress/WordPress.xcodeproj/project.pbxproj
@kean
kean self-requested a review June 18, 2024 22:41
@jkmassel
jkmassel merged commit 2229af0 into trunk Jun 18, 2024
@jkmassel
jkmassel deleted the remove/search-ads-attribution branch June 18, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants