Remove iAd (Apple Search Ads) attribution#23365
Merged
Merged
Conversation
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23365-2a61e2d | |
| Version | 25.1 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 2a61e2d | |
| App Center Build | WPiOS - One-Offs #10190 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23365-2a61e2d | |
| Version | 25.1 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 2a61e2d | |
| App Center Build | jetpack-installable-builds #9239 |
jkmassel
marked this pull request as ready for review
June 18, 2024 19:25
Contributor
|
LGTM. It seems that this API is not only deprecated but is also no longer working:
There was a relatively recent search ad-campaign, but I'm not sure if it used the attribution info. It's reasonable to assume that if we run one again, we'll need to add a new attribution tracking code. |
kean
reviewed
Jun 18, 2024
kean
self-requested a review
June 18, 2024 22:41
kean
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


We're not purchasing ads for the app, and this code is deprecated. Let's remove it for now.
Includes some Xcode project cleanup noise
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: