Remove direct wpxmlrpc usages from the app - #23389
Closed
kean wants to merge 2 commits into
Closed
Conversation
kean
force-pushed
the
task/remove-wpxmlrpc-usages
branch
from
June 26, 2024 19:35
d5708ed to
16ac4cd
Compare
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23389-3268f16 | |
| Version | 25.1 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 3268f16 | |
| App Center Build | WPiOS - One-Offs #10270 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23389-3268f16 | |
| Version | 25.1 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 3268f16 | |
| App Center Build | jetpack-installable-builds #9317 |
kean
force-pushed
the
task/remove-wpxmlrpc-usages
branch
from
July 5, 2024 22:51
16ac4cd to
92f0e61
Compare
Collaborator
Generated by 🚫 Danger |
kean
force-pushed
the
task/remove-wpxmlrpc-usages
branch
from
July 8, 2024 12:42
5ac9c99 to
bb4b561
Compare
kean
force-pushed
the
task/remove-wpxmlrpc-usages
branch
from
July 8, 2024 15:28
bb4b561 to
3268f16
Compare
kean
marked this pull request as draft
July 8, 2024 15:43
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The
wpxmlrpcwas another transient dependency declared inWordPressKit.podspecbut used directly from the app.WordPressKitnow re-export the only property fromwpxmlrpcthat was used by the app.If we end up using Xcode targets to defineWordPressKit, we'll include it as a Swift package and link it statically inWordPressKit. Either way, it's one less dependency to worry about.Update: I had to also update
WordPressAuthentificatorto remove the directwpxmlrpcusage, so it is now linked statically inWordPressKitand doesn't leak from its interface.To test:
Just to make sure it works, I span a local WP instance and changes a password:
Not sure what's up with "Updating..." in the background. I left a note to check it later.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: