Skip to content

Remove ellipsis from the share button #23975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kean merged 2 commits into from
Jan 14, 2025
Merged

Remove ellipsis from the share button #23975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6c9a39
Remove ellipsis from the share button
kean Jan 13, 2025
f903bc4
Fix typo on MediaUtilityTask
kean Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPress/Classes/ViewRelated/Blog/Blog Details/Detail Header/BlogDetailHeaderView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class BlogDetailHeaderView: UIView {

private func makeSiteLinkMenu() -> UIMenu {
UIMenu(children: [
UIAction(title: SharedStrings.Button.share + "…", image: UIImage(systemName: "square.and.arrow.up"), handler: { [weak self] _ in
UIAction(title: SharedStrings.Button.share, image: UIImage(systemName: "square.and.arrow.up"), handler: { [weak self] _ in
self?.delegate?.buttonShareSiteTapped()
}),
UIAction(title: Strings.visitSite, image: UIImage(systemName: "safari"), handler: { [weak self] _ in
Expand Down
2 changes: 1 addition & 1 deletion ...ss/Classes/ViewRelated/Blog/My Site/Header/HomeSiteHeaderViewController+SiteActions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ private enum MenuItem {
var title: String {
switch self {
case .visitSite: return Strings.visitSite
case .shareSite: return SharedStrings.Button.share + "…"
case .shareSite: return SharedStrings.Button.share
case .siteTitle: return Strings.siteTitle
case .personalizeHome: return Strings.personalizeHome
}
Expand Down
6 changes: 3 additions & 3 deletions WordPress/Classes/ViewRelated/Gutenberg/EditorMediaUtility.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class EditorMediaUtility {
callbackQueue.async {
failure(error)
}
return MeediaUtilityTask { /* do nothing */ }
return MediaUtilityTask { /* do nothing */ }
case let .success((imageURL, host)):
let task = Task { @MainActor in
do {
Expand All @@ -98,7 +98,7 @@ class EditorMediaUtility {

}
}
return MeediaUtilityTask { task.cancel() }
return MediaUtilityTask { task.cancel() }
}
}

Expand Down Expand Up @@ -202,7 +202,7 @@ class EditorMediaUtility {
}
}

private struct MeediaUtilityTask: ImageDownloaderTask {
private struct MediaUtilityTask: ImageDownloaderTask {
let closure: @Sendable () -> Void

func cancel() {
Expand Down