Skip to content

Remove an unused Coordinate model - #24154

Merged
mokagio merged 4 commits into
trunkfrom
mokagio/remove-unused-coordinate
Mar 7, 2025
Merged

Remove an unused Coordinate model#24154
mokagio merged 4 commits into
trunkfrom
mokagio/remove-unused-coordinate

Conversation

@mokagio

@mokagio mokagio commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Stumbled upon this while looking at the files in the context of #24153

It looked odd to have a model wrapping coordinates as it seemed more like something a game or app with heavy UI animations would do.

I tried to remove it and the build was green, so we should be good, right?

@wpmobilebot

wpmobilebot commented Mar 6, 2025

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24154-5f49514
Version25.7.1
Bundle IDorg.wordpress.alpha
Commit5f49514
App Center BuildWPiOS - One-Offs #11592
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

wpmobilebot commented Mar 6, 2025

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24154-5f49514
Version25.7.1
Bundle IDcom.jetpack.alpha
Commit5f49514
App Center Buildjetpack-installable-builds #10622
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio self-assigned this Mar 6, 2025
@mokagio mokagio added this to the 25.9 milestone Mar 6, 2025
@mokagio
mokagio requested review from crazytonyli and kean March 6, 2025 09:48
@mokagio
mokagio marked this pull request as ready for review March 6, 2025 09:48

@jkmassel jkmassel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty certain this was used for geotagging posts.

We haven't had that feature in a long time (as far as I know)

Let's wait until after the next code freeze to merge this though (/cc @kean )

@mokagio
mokagio added this pull request to the merge queue Mar 7, 2025
Merged via the queue into trunk with commit 85215d2 Mar 7, 2025
@mokagio
mokagio deleted the mokagio/remove-unused-coordinate branch March 7, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants