Move WPException to WordPressSharedObjC - #24157
Merged
Merged
Conversation
See conversation with @kean at #24153 (comment) This will become useful as some of the code using `WPException` will move away from the main target and into one or more modules.
mokagio
force-pushed
the
mokagio/move-wpexception-to-shared-objc
branch
from
March 6, 2025 22:19
db3cf91 to
77f91b0
Compare
Contributor
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24157-77f91b0 | |
| Version | 25.7.1 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 77f91b0 | |
| App Center Build | WPiOS - One-Offs #11597 |
Contributor
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24157-77f91b0 | |
| Version | 25.7.1 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 77f91b0 | |
| App Center Build | jetpack-installable-builds #10628 |
14 tasks
kean
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See conversation with @kean at
#24153 (comment)
This will become useful as some of the code using
WPExceptionwill move away from the main target and into one or more modules.To test
I'm not sure how to test this at runtime because I don't know how to reliably cause one of the exceptions that are trapped using
WPExcetion.At the same time, this is just a file move, so if the build is green in CI I'm quite confident we're good to go.