Move +classNameWithoutNamespaces to WordPressSharedObjC - #24164
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24164-57a9e60 | |
| Version | 25.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 57a9e60 | |
| App Center Build | WPiOS - One-Offs #11609 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24164-57a9e60 | |
| Version | 25.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 57a9e60 | |
| App Center Build | jetpack-installable-builds #10640 |
Contributor
|
Hey Gio, did you mean to base it off |
kean
approved these changes
Mar 7, 2025
kean
left a comment
Contributor
There was a problem hiding this comment.
Going to approve it to make it mergable once the commit history is updated.
Contributor
Author
So we can use it next in WordPressData.
mokagio
force-pushed
the
mokagio/share-classNameWithoutNamespaces
branch
from
March 7, 2025 20:56
81890b9 to
57a9e60
Compare
mokagio
enabled auto-merge
March 7, 2025 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



I've been trying to move the Core Data model to WordPressData but got bogged with an
NSArray element failed to match the Swift Array Element typeexception — More details in #24166.Given that work is still in progress, I thought we could at least merge this pre-condition change to move (actually duplicate for migration convenience) the
classNameWithoutNamespacesmethod onNSObjectthat the models use to create theirNSFetchRequest.WordPress-iOS/WordPress/Classes/Models/BloggingPrompt+CoreDataClass.swift
Lines 5 to 9 in 85215d2