Move AsyncOperation and AsyncBlockOperation to WordPressShared - #24185
Merged
Conversation
This is so the diff is neater next when moving it to WordPressShared
Turned out there needed to be move access control changes than those done in the previous commit...
mokagio
force-pushed
the
mokagio/asyncop
branch
from
March 11, 2025 03:56
2855ba4 to
0dba621
Compare
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24185-0dba621 | |
| Version | 25.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 0dba621 | |
| App Center Build | WPiOS - One-Offs #11626 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24185-0dba621 | |
| Version | 25.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 0dba621 | |
| App Center Build | jetpack-installable-builds #10657 |
crazytonyli
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I run into those as dependencies for the Core Data logic, see #24166 and #24165. There's lots to move in that PR, so I pushed this little self-contained change in the meantime.
I got bitten a few time by these changes where the app seems to compile fine but then crashes at runtime. So, I tested this "properly".