Convert a number of interconnected Blog methods to Swift - #24332
Closed
mokagio wants to merge 2 commits into
Closed
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24332-e6b2d96 | |
| Version | 25.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | e6b2d96 | |
| App Center Build | jetpack-installable-builds #10901 |
Contributor
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24332-e6b2d96 | |
| Version | 25.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | e6b2d96 | |
| App Center Build | WPiOS - One-Offs #11879 |
mokagio
force-pushed
the
mokagio/blog-swift-some
branch
from
March 27, 2025 04:40
938d8c5 to
b094ed1
Compare
As part of #24165, it's convenient to re-implement part of the Objective-C models to Swift, to remove code in Objective-C that accesses logic defined in the Swift layer. Regardless of where WordPressData will end up, this kind of rewrites are advantageous because they bring us a few inches closer to our goal of no longer having Objective-C code, with all the implementation benefits that will produce.
mokagio
force-pushed
the
mokagio/blog-swift-some
branch
from
April 2, 2025 03:46
e6b2d96 to
f2f81a4
Compare
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27052 | |
| Version | PR #24332 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | f2f81a4 | |
| Installation URL | 6lgjjrinvm3ig |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27052 | |
| Version | PR #24332 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | f2f81a4 | |
| Installation URL | 3lkfnr07uo98o |
Contributor
Author
|
Closing for the same reason that #24393 was closed. The code is here to cherry pick in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #24165, it's convenient to re-implement part of the Objective-C models to Swift, to remove code in Objective-C that accesses logic defined in the Swift layer.
Regardless of where WordPressData will end up, this kind of rewrites are advantageous because they bring us a few inches closer to our goal of no longer having Objective-C code, with all the implementation benefits that will produce.