Skip to content

Remove unused appRatingUtility from AppEnvironment - #24352

Merged
mokagio merged 1 commit into
trunkfrom
mokagio/cleanup-appRatingUtility
Mar 28, 2025
Merged

Remove unused appRatingUtility from AppEnvironment#24352
mokagio merged 1 commit into
trunkfrom
mokagio/cleanup-appRatingUtility

Conversation

@mokagio

@mokagio mokagio commented Mar 28, 2025

Copy link
Copy Markdown
Contributor

I noticed this unused property while working on #24351.

I'll acknowledge that we should ditch AppEnvironment altogether, but short of time to address that, this at least reduces its surface area.

Part of #24165.

I noticed this unused property while working on #24351.

I'll acknowledge that we should ditch `AppEnvironment` altogether, but
short of time to address that, this at least reduces its surface area.
@mokagio mokagio added this to the 25.9 milestone Mar 28, 2025
@mokagio
mokagio requested review from crazytonyli and kean March 28, 2025 03:16
@dangermattic

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number26830
VersionPR #24352
Bundle IDcom.jetpack.alpha
Commitec6ae5a
Installation URL7p7803nqq2rm0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number26830
VersionPR #24352
Bundle IDorg.wordpress.alpha
Commitec6ae5a
Installation URL1k7la7vnngs6g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio
mokagio enabled auto-merge March 28, 2025 03:58
@mokagio
mokagio added this pull request to the merge queue Mar 28, 2025
Merged via the queue into trunk with commit b1a53bb Mar 28, 2025
@mokagio
mokagio deleted the mokagio/cleanup-appRatingUtility branch March 28, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants