Skip to content

Use wpAssertionFailure in TaggedManagedObjectID - #24376

Merged
mokagio merged 2 commits into
trunkfrom
mokagio/tagged-wpassertion
Apr 1, 2025
Merged

Use wpAssertionFailure in TaggedManagedObjectID#24376
mokagio merged 2 commits into
trunkfrom
mokagio/tagged-wpassertion

Conversation

@mokagio

@mokagio mokagio commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

After all, the goal of the code was to log the error, which wpAssertionFailure allows to do.

Removing the app delegate access unblocks moving TaggedManagedObjectID away from the apps targets and into WordPressData.

Alternatively, we could just remove the logging entirely. The original comment did mention monitoring the error for a few releases, but that was some time ago...

Part of #24165.

mokagio added 2 commits April 1, 2025 21:53
After all, the goal of the code was to log the error, which
`wpAssertionFailure` allows to do.

Removing the app delegate access unblocks moving `TaggedManagedObjectID`
away from the apps targets and into WordPressData.
@mokagio mokagio self-assigned this Apr 1, 2025
@mokagio
mokagio requested review from crazytonyli and kean April 1, 2025 11:01
@mokagio mokagio added this to the 25.9 milestone Apr 1, 2025
@mokagio mokagio added the Core Data Issues related to Core Data label Apr 1, 2025
@dangermattic

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number26986
VersionPR #24376
Bundle IDorg.wordpress.alpha
Commit00f32c1
Installation URL238hnq5eip6j0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number26986
VersionPR #24376
Bundle IDcom.jetpack.alpha
Commit00f32c1
Installation URL5drk9ievds03g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio
mokagio added this pull request to the merge queue Apr 1, 2025
Merged via the queue into trunk with commit ed2f112 Apr 1, 2025
@mokagio
mokagio deleted the mokagio/tagged-wpassertion branch April 1, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Data Issues related to Core Data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants