Remove WordPressDataObjC and WordPressData modules - #24402
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the unused WordPressDataObjC and WordPressData modules to resolve dependency issues and reduce dead weight in the codebase.
- Removed the import of WordPressDataObjC from the CoreDataStackSwift.swift file.
- Deleted the empty header file in WordPressDataObjC and its corresponding Swift module import in WordPressData.swift.
- Updated the Package.swift file by removing library declarations and target definitions related to WordPressData and WordPressDataObjC.
Reviewed Changes
Copilot reviewed 16 out of 32 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WordPress/Classes/Models/CoreDataStack/CoreDataStackSwift.swift | Removed an unnecessary import to eliminate dependency issues. |
| Modules/Sources/WordPressDataObjC/include/Empty.h | Deleted an empty header file as part of the deprecation. |
| Modules/Sources/WordPressData/WordPressData.swift | Removed an export of the now removed WordPressDataObjC module. |
| Modules/Package.swift | Removed library and target definitions related to WordPressData and WordPressDataObjC to fully clean up unused modules. |
Files not reviewed (16)
- Modules/Sources/WordPressDataObjC/Empty.m: Language not supported
- WordPress/Classes/Categories/Media+Extensions.m: Language not supported
- WordPress/Classes/Models/AbstractPost.m: Language not supported
- WordPress/Classes/Models/BasePost.m: Language not supported
- WordPress/Classes/Models/Blog/Blog.m: Language not supported
- WordPress/Classes/Models/Media.m: Language not supported
- WordPress/Classes/Models/ReaderPost.m: Language not supported
- WordPress/Classes/Models/Theme.m: Language not supported
- WordPress/Classes/Services/BlogService.m: Language not supported
- WordPress/Classes/Services/CommentService.m: Language not supported
- WordPress/Classes/Services/Facades/BlogSyncFacade.m: Language not supported
- WordPress/Classes/Services/MediaService.m: Language not supported
- WordPress/Classes/Services/MenusService.m: Language not supported
- WordPress/Classes/Services/PostCategoryService.m: Language not supported
- WordPress/Classes/Services/PostService.m: Language not supported
- WordPress/Classes/Services/PostTagService.m: Language not supported
mokagio
enabled auto-merge
April 3, 2025 10:52
It was good to have it there as a placeholder, but it's giving me some odd compilation issue where the extensions seem to think they need it as a dependency. It was empty anyway, so effectively dead weight. It'll be easy enough to recreate it when the time comes.
Same rationale as the `WordPressDataObjC` removal in the previous commit. It was dead weight. Plus, it could be confusing to have a module (albeit empty and unused) and a framework with the same name.
mokagio
force-pushed
the
mokagio/remove-wordpressdata-spm
branch
from
April 3, 2025 10:54
9b05685 to
da17ea8
Compare
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27088 | |
| Version | PR #24402 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | da17ea8 | |
| Installation URL | 4uo8g1nc3lcbg |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27088 | |
| Version | PR #24402 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | da17ea8 | |
| Installation URL | 57jelltblui68 |
kean
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was good to have them there as placeholders, but
WordPressDataObjCin particular was giving me some odd compilation issue in #24378 where the extensions seem to think they need it as a dependency. And once I remove that, it made no sense to keepWordPressData.It was empty anyway, so effectively dead weight. It'll be easy enough to recreate it when the time comes.
Part of #24165