Skip to content

Remove duplicated SFHFKeychainUtils dependency from WordPressUnitTests - #24514

Merged
mokagio merged 1 commit into
trunkfrom
mokagio/remove-duplicated-package-declaration
May 4, 2025
Merged

Remove duplicated SFHFKeychainUtils dependency from WordPressUnitTests#24514
mokagio merged 1 commit into
trunkfrom
mokagio/remove-duplicated-package-declaration

Conversation

@mokagio

@mokagio mokagio commented May 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Noticed this because Xcode added a warning sign next to the Modules in the file navigator. Probably a rebase / merge conflict byproduct.

image

image

@mokagio
Remove duplicated SFHFKeychainUtils dependency from WordPressUnitTests
9fba4e9 
Noticed this because Xcode added a warning sign next to the Modules in
the file navigator.
mokagio
mokagio commented May 2, 2025
View reviewed changes
Comment thread Modules/Package.swift
.xcodeTarget("XcodeTarget_App", dependencies: keystoneDependencies),
.xcodeTarget("XcodeTarget_Keystone", dependencies: keystoneDependencies),
.xcodeTarget("XcodeTarget_WordPressTests", dependencies: testDependencies + [
"SFHFKeychainUtils",

@mokagio mokagio May 2, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining one is below at line 324

@mokagio
mokagio requested review from crazytonyli and kean May 2, 2025 06:49
@mokagio mokagio added this to the 26.1 milestone May 2, 2025
@dangermattic

dangermattic commented May 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).

Generated by 🚫 Danger

@mokagio mokagio added the Testing Unit and UI Tests and Tooling label May 2, 2025
@sonarqubecloud

sonarqubecloud Bot commented May 2, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wpmobilebot

wpmobilebot commented May 2, 2025

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27570
VersionPR #24514
Bundle IDorg.wordpress.alpha
Commit9fba4e9
Installation URL31uqqu3n76slo
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

wpmobilebot commented May 2, 2025

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27570
VersionPR #24514
Bundle IDcom.jetpack.alpha
Commit9fba4e9
Installation URL2is5ui9153l9o
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio
mokagio added this pull request to the merge queue May 4, 2025
Merged via the queue into trunk with commit fd16fb1 May 4, 2025
@mokagio
mokagio deleted the mokagio/remove-duplicated-package-declaration branch May 4, 2025 23:45
@mokagio mokagio mentioned this pull request May 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazytonyli crazytonyli crazytonyli approved these changes
@kean kean Awaiting requested review from kean

Assignees

No one assigned

Labels

Testing Unit and UI Tests and Tooling

Projects

None yet

Milestone

26.1

Development

Successfully merging this pull request may close these issues.

4 participants

@mokagio @dangermattic @wpmobilebot @crazytonyli