Post Settings: Scaffolding - #24622
Merged
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
kean
force-pushed
the
task/post-settings-initial-version
branch
from
June 25, 2025 18:09
e6075c0 to
bcb3e07
Compare
|
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27986 | |
| Version | PR #24622 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | bcb3e07 | |
| Installation URL | 4f4oacanl8n40 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27986 | |
| Version | PR #24622 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | bcb3e07 | |
| Installation URL | 6mc8n42b5ptk0 |
crazytonyli
reviewed
Jul 3, 2025
| import WordPressData | ||
|
|
||
| final class PostSettingsViewModel: ObservableObject { | ||
| let post: AbstractPost |
Contributor
There was a problem hiding this comment.
Since PostSettingsViewModel is an ObservableObject, should you @Publish this property? Otherwise, I guess there will be no update in PostSettingsViewModel instances?
Contributor
Author
There was a problem hiding this comment.
That's not the intention as the only observable bits we care about are modeled using @Published var settings: PostSettings.
should you @publish this property
A @Published property on a let doesn't really do anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a FF and an initial empty-ish VC that will contains the reworked screen.