Post Settings: General Section - #24635
Merged
Merged
Conversation
…t is not editable
kean
commented
Jun 26, 2025
| } | ||
| // TODO: implement it for the remaining field | ||
| // Create a temporary copy of the post to apply the new settings | ||
| let temporaryPost = original.createRevision() |
Contributor
Author
There was a problem hiding this comment.
I figured it would be easier to do than duplicating it for PostSettings.
| // Apply settings to the post and mark for sync | ||
| settings.apply(to: post) | ||
| coordinator.setNeedsSync(for: post) | ||
| let revision = post.createRevision() |
Contributor
Author
There was a problem hiding this comment.
Totally forgot to add it in the previous PRs. The synced changed must be in a revision.
|
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 28026 | |
| Version | PR #24635 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | f67479f | |
| Installation URL | 5c17o3bvdhe3g |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 28026 | |
| Version | PR #24635 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | f67479f | |
| Installation URL | 7n7i54elb66t8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.