Reader: Fix colors in post inline comment section#25456
Merged
Conversation
Collaborator
kean
commented
Mar 26, 2026
| } | ||
|
|
||
| /* workaround for CMM-1964 */ | ||
| .reader-full-post.reader-full-post__story-content { |
Contributor
Author
There was a problem hiding this comment.
This actually wasn't working. I'm not sure how I previously tested it. It required a more specific qualifier (dark scheme).
kean
commented
Mar 26, 2026
| } | ||
| } | ||
|
|
||
| .reader-full-post__story-content .wp-block-button { |
Contributor
Author
There was a problem hiding this comment.
I included a fix for button style from trunk too.
|
kean
changed the title
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31792 | |
| Version | PR #25456 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 86d83d3 | |
| Installation URL | 0lotm7tvr0un0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31792 | |
| Version | PR #25456 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 86d83d3 | |
| Installation URL | 6vjkb5hf4nekg |
crazytonyli
approved these changes
Mar 26, 2026
crazytonyli
pushed a commit
that referenced
this pull request
Mar 26, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 26, 2026
* Show more detailed application password login errors (#25454) * Fix colors in post inline comment section (#25456) * Revert a localizable string change (#25460) Introduced in #25454, and caused trouble in the release process: > Inconsistencies found between 'en' and 'zh-Hant': > `addSite.selfHosted.loadingSiteInfoFailure` expected placeholders for [String] but found [] instead. * Update strings for localization * Update app translations – `Localizable.strings` * Update WordPress metadata translations * Update Jetpack metadata translations * Bump version number --------- Co-authored-by: Tony Li <tony.li@automattic.com> Co-authored-by: Alex Grebenyuk <alex.grebenyuk@automattic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CMM-1987: Reader: Incorrect inline comments colors on dark mode with non-dynamic theme
I identified and fixed a couple of more issues when testing Reader Preferences.
Changes
ReaderDisplaySettingsKnown issue: comment style doesn't refresh when you change a theme (minor)