Add the ability to import and export saved posts. by twstokes · Pull Request #25509 · wordpress-mobile/WordPress-iOS

twstokes · 2026-04-23T20:56:21Z

Summary

Saved Reader posts are local-only and don't sync across devices. This adds the ability to import and export them as a JSON file, so users can back up their saved posts or transfer them between devices/apps.
Accessible from Me → App Settings → Other → Saved Posts
Export produces a {AppName}-Saved-Posts-{date}.json file containing post metadata (URL, title, author, site, date, summary, tags, featured image, siteID, postID) along with the app version that exported it.
Import parses the JSON, then fetches each post from the WordPress.com API through the normal ReaderPostService pipeline to create fully-populated Core Data objects. Posts are fetched sequentially to avoid race conditions. Deduplication uses permaLink — posts whose URL is already saved are skipped, so importing the same file multiple times or merging lists from different devices is safe.
A progress bar is shown during import since each post requires a network round-trip.
The result reports imported, skipped (already saved), and failed (API errors) counts.
Adds three Tracks events: `reader_saved_posts_settings_shown` (screen appears), `reader_saved_posts_exported` (successful export), and `reader_saved_posts_imported` (with imported/skipped/failed counts).

Reader -> Saved	Settings -> Saved Posts	Saved Posts

Test plan

🤖 Generated with Claude Code

dangermattic · 2026-04-23T20:56:58Z

	1 Warning
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

wpmobilebot · 2026-04-23T21:09:14Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`32261`
	Version	`PR #25509`
	Bundle ID	`org.wordpress.alpha`
	Commit	`0b1882d`
	Installation URL	5g8pe0pghi128

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-04-23T21:09:26Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`32261`
	Version	`PR #25509`
	Bundle ID	`com.jetpack.alpha`
	Commit	`0b1882d`
	Installation URL	56bpei6s865bo

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-05-05T18:26:19Z

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

@published

Lets the VM be unit-tested without ContextManager.shared, and marks the alert message strings @published so SwiftUI re-reads them when the isShowing* flag flips.

Adds three Tracks events: - reader_saved_posts_settings_shown when the screen appears - reader_saved_posts_exported on a successful export - reader_saved_posts_imported with imported/skipped/failed counts

jkmassel · 2026-05-09T15:51:38Z

+        let appName = (Bundle.main.object(forInfoDictionaryKey: "CFBundleDisplayName") as? String) ?? "WordPress"
+        let appVersion = Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString") as? String


These can be force-unwrapped – we'd never ship a release that doesn't have them.

Realistically we should have a helper that does it for you 🤷

Makes sense – handled in 258f148.

crazytonyli · 2026-05-10T22:25:12Z

+import WordPressData
+
+/// Handles exporting and importing saved Reader posts as JSON files.
+struct ReaderSavedPostsExporter {


The implementation does not quite follow the patterns used widely in the app. I have added a doc in #25551. I wonder if you can prompt AI to rewrite to follow the updated best practices?

Sounds good! Once that's merged I can have it do another pass.

If we're taking another look at this, I'd really like to see any serialization and parsing use Codable – String:Any is too loose about the format (which means we don't get compile-time detection of problems, we get runtime ones)

Good call, addressed with ee074ab.

crazytonyli · 2026-05-10T22:27:43Z

Instead of arbitrary JSON, what do you think about using the standard RSS?

Replaces [String: Any] envelopes with typed Envelope and ExportedPost structs so the JSON format is validated at compile time rather than at runtime.

crazytonyli · 2026-05-14T10:01:18Z

+        coreDataStack: CoreDataStack,
+        progress: @escaping (Int, Int) -> Void,
+        completion: @escaping (ImportResult) -> Void
+    ) {


I think making this function async would simplify the implementation:

You can take Progress (which SwiftUI supports) as a parameter, and update its completedUnit and totalUnit in this function to surface importing progress.

You can use TaskGroup to import posts in parallel.

It'd be impossible to forget calling the completion block.

The implementation uses coreDataStack.mainContext, which means the function must be called from the main thread. You can enforce that by declaring the function @MainActor. However, I don't think this is necessary, because you should be able to use coreDataStack.performAndSave to save Core Data after a post is imported.

Had Claude tackle this with 7858b9f.

crazytonyli · 2026-05-14T10:08:22Z

+
+    func exportSavedPosts() {
+        do {
+            guard let fileURL = try exporter.export(context: coreDataStack.mainContext) else {


It's probably best to export in a background thread.

Moved off main thread in 50530f8 and added a progress view in 0b1882d.

crazytonyli · 2026-05-14T10:14:53Z

+                featuredImageURL: (featuredImage?.isEmpty ?? true) ? nil : featuredImage,
+                siteID: siteID > 0 ? siteID : nil,
+                postID: postID > 0 ? postID : nil,
+                isFeed: post.isExternal


I think you'll need to include the feed id and feed item id in the JSON, when isExternal is true? When it's true, I think the siteId and postId would be nil.

Refactor ReaderSavedPostsExporter.importPosts into an async function that returns its result directly instead of using progress/completion closures: - Take a Progress parameter and update its unit counts so callers can surface import progress (the view model observes it via KVO). - Import posts concurrently with a bounded TaskGroup instead of recursing sequentially, while still capping concurrency to avoid flooding the API. - Drop the completion block so the result can no longer be forgotten. - Use performQuery/performAndSave on a background context instead of mainContext, removing the implicit main-thread requirement. Update the view model to call the async API and the tests accordingly.

ReaderSavedPostsExporter.export now takes a CoreDataStackSwift and is async. The Core Data fetch happens inside performQuery on a background context (mapping each ReaderPost to a value-type ExportedPost so no managed object escapes the closure), and the JSON encoding and file write also run off the main thread. The view model invokes the export from a Task and updates UI state on resume.

Add an isExporting flag that drives an indeterminate ProgressView with "Preparing export…" text in the section, and gate both Import and Export buttons on a new isBusy computed property so neither can be re-tapped while either operation is in flight.

twstokes force-pushed the reader-import-export branch from d2b6618 to 8209a08 Compare April 30, 2026 14:43

twstokes marked this pull request as ready for review April 30, 2026 15:10

twstokes added the [Type] Enhancement label Apr 30, 2026

twstokes added this to the 26.9 milestone Apr 30, 2026

twstokes force-pushed the reader-import-export branch from 3b1a46f to 06c723d Compare May 5, 2026 18:07

twstokes added 2 commits May 5, 2026 17:24

Add the ability to import and export saved posts.

3c195ad

Show option to import / export saved posts on Reader -> Saved.

6f4c403

twstokes force-pushed the reader-import-export branch from 06c723d to 6f4c403 Compare May 5, 2026 21:27

twstokes added 4 commits May 5, 2026 17:35

Fix lint error.

c486bba

Inject CoreDataStack into ReaderSavedPostsSettingsViewModel.

9976452

Lets the VM be unit-tested without ContextManager.shared, and marks the alert message strings @published so SwiftUI re-reads them when the isShowing* flag flips.

Track Reader saved posts import/export usage.

79bd8f1

Adds three Tracks events: - reader_saved_posts_settings_shown when the screen appears - reader_saved_posts_exported on a successful export - reader_saved_posts_imported with imported/skipped/failed counts

Merge branch 'trunk' into reader-import-export

1209432

twstokes requested review from crazytonyli and jkmassel May 8, 2026 16:31

jkmassel reviewed May 9, 2026

View reviewed changes

crazytonyli reviewed May 10, 2026

View reviewed changes

twstokes added 2 commits May 10, 2026 20:39

Force unwrap app name and version.

258f148

Use Codable types for saved posts export/import format

ee074ab

Replaces [String: Any] envelopes with typed Envelope and ExportedPost structs so the JSON format is validated at compile time rather than at runtime.

crazytonyli reviewed May 14, 2026

View reviewed changes

twstokes added 2 commits May 19, 2026 16:59

Merge branch 'trunk' into reader-import-export

cca9faa

twstokes modified the milestones: 26.9, 27.0 May 19, 2026

twstokes added 2 commits May 19, 2026 17:29

		let appName = (Bundle.main.object(forInfoDictionaryKey: "CFBundleDisplayName") as? String) ?? "WordPress"
		let appVersion = Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString") as? String

Conversation

twstokes commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

dangermattic commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Build Failure Analysis

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkmassel May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crazytonyli commented May 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

twstokes commented Apr 23, 2026 •

edited

Loading

dangermattic commented Apr 23, 2026 •

edited

Loading

wpmobilebot commented Apr 23, 2026 •

edited

Loading

wpmobilebot commented Apr 23, 2026 •

edited

Loading

wpmobilebot commented May 5, 2026 •

edited

Loading

jkmassel May 11, 2026 •

edited

Loading