Grid view in the new media screen#25561
Draft
crazytonyli wants to merge 21 commits into
Draft
Conversation
Collaborator
Generated by 🚫 Danger |
crazytonyli
force-pushed
the
task/media-v2-grid
branch
from
c106304 to
512afad
Compare
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
crazytonyli
force-pushed
the
task/media-v2-grid
branch
from
512afad to
3abc15a
Compare
Distinct accessibility label for failed-without-data placeholders so VoiceOver doesn't read "Loading media" over an error icon. Inner image content takes the 4pt rounding in aspect-ratio mode, leaving the outer cell square for non-square images to match V1's container-level rounding. Comment updates for loadItems' intentional log-only error path, setFilter analytics flow, and MediaGridDuration's deliberate locale-neutral format.
Video cells now render via CachedAsyncImage(videoUrl:) instead of the generic play icon, restoring V1 surface parity for video thumbnails. Documents-filter narrowing vs V1 documented inline on MediaKind so the wp-rs Phase 0 follow-up is visible from the code. Adds eight unit tests for MediaGridLayoutMath covering V1's 4-per-row / 5-per-row threshold, spacing modes, and cell-size rounding.
Inner image .aspectRatio(.fit) on a .resizable() CachedAsyncImage was rendering at intrinsic pixel-derived size under an infinite frame proposal, overflowing the cell horizontally into adjacent grid positions. Wraps the cell body in a GeometryReader so the inner image content gets an explicit square frame constraint. Accepts the small V1-parity deviation flagged by code-review-1 finding 2 (outer cell rounds whole vs V1's inner-container-only) because the alternative caused this overflow bug.
crazytonyli
force-pushed
the
task/media-v2-grid
branch
from
883a054 to
18ef295
Compare
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32246 | |
| Version | PR #25561 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 18ef295 | |
| Installation URL | 1ka1tvlc2h9e8 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32246 | |
| Version | PR #25561 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 18ef295 | |
| Installation URL | 4oqi37moa3dco |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR will be merged after #25560.
Description
Similar to the existing Media screen, the grid view is 4 columns in compact width and 5 in regular, supports the same aspect-ratio / square toggle as V1 (sharing the UserDefaults key, so the preference carries over between the two screens), and renders per-kind cells for image, video, audio, and document.
Analytics for filter, search, and the grid toggle are routed through
MediaTrackerAdapterto Tracks under newWPAnalyticsStatcases that mirror V1's event names.