Skip to content

Remove simulated pull to refresh from most views - #360

Merged
mikejohnstn merged 4 commits into
developfrom
issues/355
Nov 13, 2013
Merged

Remove simulated pull to refresh from most views#360
mikejohnstn merged 4 commits into
developfrom
issues/355

Conversation

@mikejohnstn

Copy link
Copy Markdown
Contributor

As discussed in #355, the simulated pull to refresh is distracting. This pull removes all of them except those in web views, which are handled differently.

This change led to a simplification of the API for syncing items in tables. I decoupled regular background syncing and user-initiated syncing, with the former now called via a simple syncItems. Manual syncing (e.g. via a pull to refresh) allows subclasses to do extra stuff if they need to.

I intended to preserve all "extra stuff" that's done by a manual refresh (including post pruning and the syncing of extra metadata), but a careful review is in order since this affects so many views.

Before/after:
nopullrefresh

- Syncing typically now achieved via a simple syncItems call.
- Alternate path available for user-initiated syncs.
- These two paths are now decoupled and explicit.
@mikejohnstn

Copy link
Copy Markdown
Contributor Author

As per @koke's comment #355 (comment) I'll also update this to use UIRefreshControl. Good call, though we won't be able to rip EGO yet since it's still buried in web views and I'd rather not touch those with this pull.

@koke could you put comments about additions etc. in the pull request next time instead of the issue? It aggregates a nice conversation about the implementation details.

@mikejohnstn

Copy link
Copy Markdown
Contributor Author

nativerefresh

@mikejohnstn

Copy link
Copy Markdown
Contributor Author

With these changes, after first signing in, I believe you're left staring at a blank screen for too long. I've added #376 to consider improving this case.

mikejohnstn added a commit that referenced this pull request Nov 13, 2013
Remove simulated pull to refresh from most views
@mikejohnstn
mikejohnstn merged commit 2b18f4e into develop Nov 13, 2013
@mikejohnstn
mikejohnstn deleted the issues/355 branch November 13, 2013 09:02
koke added a commit that referenced this pull request Nov 14, 2013
In 8b5ae3e, the `scrollViewDidScroll:`
method was removed from `WPTableViewController`. Don't call `super` from
`ReaderPostsViewController` since that method doesn't exist anymore

refs #360 #355
@astralbodies

Copy link
Copy Markdown
Contributor

@mikejohnstn I'm looking through WPTableViewController, and I see the new method syncItemsViaUserInteractionWithSuccess:success:failure: but I don't see that the method is actually called anywhere. Can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants