Issue/4756 Reorganizes appearance of geotagging and post defaults.

[kurzee]

As discussed in #4757, the best approach for resolving our feature confusion with default post options is to disable toggling the options for non-admin or XML-RPC users in Site Settings.

This PR changes the Site Settings to only show the default post options for admin REST API users. This also moves the Geotagging option within a new section titled "This Device", which is available for all users.

This brings parity with the Calypso web handling of default post options, in which the options are only available sites connected as admin users.

The only concern I could see with this change is potential confusion with any users who might have already changed their default post options in-app as non-admin REST or XML-RPC users. An upcoming update including this change would disallow them from changing their default options again, in-app. The only way for the user to update their previously made changes in-app would be to re-connect their site or account, restoring the site defaults.

REST Testing:

1. Open Site Settings for a site connected via the REST-API and as an admin user.
2. Observe the available default category, post format and related posts options.
3. Observe the available Geotagging option under "This Device".

REST Testing:

1. Open Site Settings for a site connected via the REST-API and as a non-admin user.
2. Observe no availability for the default category, post format and related posts options.
3. Observe the available Geotagging option under "This Device".

XML-RPC Testing:

1. Open Site Settings for a site connected via the XML-RPC.
2. Observe no availability for the default category, post format and related posts options.
3. Observe the available Geotagging option under "This Device".

@aerych please review. Also, @mattmiklic please review the text changes.

[kurzee]

[mattmiklic]

Tested all three states and design looks good.

I noticed for a REST blog, admin user, the "This Device" section is above writing. Can we move that so that it always appears at the bottom of the list of settings (but still above the "remove site" button if xml-rpc)?

[aerych]

Can we move that so that it always appears at the bottom of the list

I was going to ask the same thing ;)

[aerych]

The only concern I could see with this change is potential confusion with any users who might have already changed their default post options in-app as non-admin REST or XML-RPC users. An upcoming update including this change would disallow them from changing their default options again, in-app. The only way for the user to update their previously made changes in-app would be to re-connect their site or account, restoring the site defaults.

Ouch.
In that case, should the defaults be cleared if the user does not have the feature? I'm not sure. Being stuck with one they previously chose vs using what the app would normally default to otherwise doesn't seem like too much of a difference to me, but I do share the concern.

[kurzee]

Added commit to move "This Device" to below all options except "Advanced" and "Delete Site" options. I think it should still be above the Advanced section as it is more in-context with the items above it.

[kurzee]

In that case, should the defaults be cleared if the user does not have a REST connection?

I would then worry that the maintenance method for clearing that up would be a bit messy.

[mattmiklic]

I think it should still be above the Advanced section as it is more in-context with the items above it.

Makes sense; delete site is similar to remove site for self-hosted, makes sense to keep that at the very bottom.

[aerych]

I would then worry that the maintenance method for clearing that up would be a bit messy.

Fair enough. We should probably give a heads up to our friendly HEs that this is a potential question. cc @rachelmcr

[kurzee]

Pushed a commit that changes the behavior of using the currently set default post category and format to instead relying on the remote setting, or using app defaults as expected.

To test:

1. Switch to the develop branch.
2. Open Settings for a XML-RPC site or non-admin site.
3. Recreate the issue by selecting new default post options.
4. Observe these are selected by creating a new post and viewing the settings for the post.
5. Close app. Switch to issue/4756-settings-post-defaults branch.
6. Open settings for same site and observe no options for default post options.
7. Open editor and view settings, observe default "Uncategorized" and "Standard" are selected for category and format.

[rachelmcr]

Thanks for the heads up! It looks like this is no longer an issue, with the new approach in #4767, so I'll just keep an eye on those changes during beta testing.

[aerych]

Thanks @rachelmcr :)