Issues/blog settings cleanup - #4778
Conversation
|
|
||
| - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath | ||
| { | ||
| [tableView deselectSelectedRowWithAnimation:YES]; |
There was a problem hiding this comment.
Since we add deselectSelectedRowWithAnimation: here it will prevent the default UITableViewController behavior via clearsSelectionOnViewWillAppear. Not a big deal, but general behavior to have a cell stay selected until returning from a detail view.
There was a problem hiding this comment.
This was a deliberate change as its absence looked odd, and its addition matches the behavior in most other table views throughout the app.
but general behavior to have a cell stay selected until returning from a detail view.
I wouldn't say this is the general behavior in the app today (based on a quick ack), but maybe it should be. I hadn't noticed the cell highlight dismissing after tapping the back button but now I can't unsee it. :P Let's revert this guy.
|
@aerych code looks good minus the cell selection changes. Minor detail, but as you mentioned, this view controller could probably use a larger refactor. |
|
Thanks @kurzee !! |
…leanup Issues/blog settings cleanup
2 participants
This is a follow up to #4777 and should wait until #4777 is merged.
Just a bit of house keeping and code style cleanup on the blog settings vc. Blog settings would greatly benefit from a larger refactor to a view model, but that's something for another time.
Needs review: @kurzee (Thanks in advance!)