Refactor ImmuTablePresenter/Controller/VC - #4791
Merged
Merged
Conversation
The main goal is to remove `visible` from `ImmuTablePresenter`, since it doesn't really belong there. Presenter is a thing that can "present" view controllers: usually a UIViewController, but implemented as a protocol so it's testable. But then I realized, the Controller doesn't really need a reference to Presenter, or the parent View Controller. The only thing that needs that is ImmuTable (for the callbacks), and we can pass the presenter when requesting the table view model (renamed). This is similar to the previous solution, but avoids the chicken-and-egg problem when initiailizing. And because of this, it removes 4 assertions/preconditions that are now guaranteed at compile time. The `visible` observable is still exposed on ImmuTableViewController, but the VC is the one pausing the subscription to tableViewModel and errorMessage, instead of relying on the controller. I like this slightly less semantically, but it makes everything much simpler with initialization.
|
|
||
| protocol ImmuTablePresenter: class { | ||
| var visible: Observable<Bool> { get } | ||
| func push(controllerGenerator: ImmuTableRowControllerGenerator) -> ImmuTableAction |
Contributor
There was a problem hiding this comment.
Your previous version of this PR added a present method here, too. Should it be in this version?
Member
Author
There was a problem hiding this comment.
It's not being used yet, so I think I'll add it on the plans list changes, which need to present the details modally
koke
added a commit
that referenced
this pull request
Feb 8, 2016
…-presenter-take-2 Refactor ImmuTablePresenter/Controller/VC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal is to remove
visiblefromImmuTablePresenter, since itdoesn't really belong there. Presenter is a thing that can "present" view
controllers: usually a UIViewController, but implemented as a protocol so it's
testable.
But then I realized, the Controller doesn't really need a reference to
Presenter, or the parent View Controller. The only thing that needs that is
ImmuTable (for the callbacks), and we can pass the presenter when requesting
the table view model (renamed). This is similar to the previous solution, but
avoids the chicken-and-egg problem when initiailizing. And because of this, it
removes 4 assertions/preconditions that are now guaranteed at compile time.
The
visibleobservable is still exposed on ImmuTableViewController, butthe VC is the one pausing the subscription to tableViewModel and errorMessage,
instead of relying on the controller. I like this slightly less semantically,
but it makes everything much simpler with initialization.
Needs Review: @frosty