Skip to content

Tracks some additional Helpshift events. - #6173

Merged
diegoreymendez merged 4 commits into
developfrom
issue/3470-better-helpshift-messages
Nov 15, 2016
Merged

Tracks some additional Helpshift events.#6173
diegoreymendez merged 4 commits into
developfrom
issue/3470-better-helpshift-messages

Conversation

@diegoreymendez

@diegoreymendez diegoreymendez commented Nov 7, 2016

Copy link
Copy Markdown
Contributor

Fixes #3470.

Also removes events WPAnalyticsStatSupportSentMessage and WPAnalyticsStatSupportSentReplyToSupportMessage since:

  1. There was no way to track those, and
  2. They kind of overlap with WPAnalyticsStatSupportReceivedResponseFromSupport which is already tracked.

/cc @sendhil - Ready for review

@diegoreymendez

Copy link
Copy Markdown
Contributor Author

Doubt: even if the enum name changed for WPAnalyticsStatSupportSentMessage we may want to keep the original property flag.

Thoughts?

@diegoreymendez

Copy link
Copy Markdown
Contributor Author

/cc @astralbodies - Can I ask you for a review?

@diegoreymendez

Copy link
Copy Markdown
Contributor Author

@frosty - Can I bother you with a review?

@frosty

frosty commented Nov 15, 2016

Copy link
Copy Markdown
Contributor

@diegoreymendez Other than the conflict with Podfile.lock, the changes look good to me! Regarding changing the flag, I don't feel I know enough about our analytics setup to really make a recommendation. I like the fact that if we change it, it's consistent with the other new flags. Also, it looks like it's been changed on Android, so perhaps we should follow their lead.

:shipit:

@diegoreymendez

Copy link
Copy Markdown
Contributor Author

Ty @frosty !

@diegoreymendez
diegoreymendez merged commit 82dd6c1 into develop Nov 15, 2016
@diegoreymendez
diegoreymendez deleted the issue/3470-better-helpshift-messages branch November 15, 2016 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants