Skip to content

Media Library #2: Media URL sharing - #6851

Merged
frosty merged 2 commits into
developfrom
feature/media-library-sharing
Mar 10, 2017
Merged

Media Library #2: Media URL sharing#6851
frosty merged 2 commits into
developfrom
feature/media-library-sharing

Conversation

@frosty

@frosty frosty commented Mar 9, 2017

Copy link
Copy Markdown
Contributor

Hopefully a simple one, this – adds the ability to share a media item's URL.

To test:

  • View a media item in the media library
  • Tap the Share button in the navigation bar
  • Check you get the URL out correctly. Make sure the URL works for self-hosted and .com.

media-share

Needs review: @kurzee

@frosty frosty added the Media label Mar 9, 2017
@frosty frosty added this to the 7.2 milestone Mar 9, 2017
@frosty
frosty requested a review from kurzee March 9, 2017 19:51
present(activityController, animated: true, completion: nil)
} else {
let alertController = UIAlertController(title: nil, message: NSLocalizedString("Unable to get URL for media item.", comment: "Error message displayed when we were unable to copy the URL for an item in the user's media library."), preferredStyle: .alert)
alertController.addCancelActionWithTitle(NSLocalizedString("Dismiss", comment: ""))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment for this one

@kurzee kurzee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frosty looks good, works! :shipit:

@frosty
frosty merged commit 7db50a4 into develop Mar 10, 2017
@frosty

frosty commented Mar 10, 2017

Copy link
Copy Markdown
Contributor Author

Thanks @kurzee!

@frosty
frosty deleted the feature/media-library-sharing branch March 10, 2017 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants