Skip to content

Feature/7675 password challenge - #7918

Merged
aerych merged 9 commits into
developfrom
feature/7675-password-challenge
Oct 13, 2017
Merged

Feature/7675 password challenge#7918
aerych merged 9 commits into
developfrom
feature/7675-password-challenge

Conversation

@aerych

@aerych aerych commented Oct 8, 2017

Copy link
Copy Markdown
Contributor

Refs #7675
This PR wires up the password challenge step shown when a user attempts to login via google but a matching wpcom account has not yet been connected.

Prep:

  • Create a Google account.
  • Create a wpcom account with the google account's email address.

To test:

  • Via a browser, log into wpcom and view your account settings page. Choose the Social Login tab and confirm the account is not connected.
  • On the email login screen, tap to log in via Google.
  • Authenticate with the Google account you created.
  • Confirm the password screen in shown and shows the text from the mock up.
  • Authenticate to wpcom.
  • Via a browser, log into wpcom and view your account settings page. Choose the Social Login tab and confirm the account is connected.

Confirm that all tests pass.

Needs review: @nheagy

@aerych aerych added the Login label Oct 8, 2017
@aerych aerych added this to the 8.7 milestone Oct 8, 2017
@aerych
aerych requested a review from nheagy October 8, 2017 22:59

@nheagy nheagy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

:shipit:

@nheagy nheagy mentioned this pull request Oct 13, 2017
17 tasks
@aerych

aerych commented Oct 13, 2017

Copy link
Copy Markdown
Contributor Author

Thanks Nate!!!

@aerych
aerych merged commit e682995 into develop Oct 13, 2017
@aerych
aerych deleted the feature/7675-password-challenge branch October 13, 2017 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants