Login: Add 2FA support for social login - #8010
Conversation
| guard let _ = loginFields.nonceInfo else { | ||
| return | ||
| } | ||
| sendCodeButton.isHidden = true |
There was a problem hiding this comment.
Maybe a bit pedantic, but since this isn't related to a text field maybe create a new method so there is harmony between the method name and the work being done?
There was a problem hiding this comment.
This is a good idea.
| if let newNonce = (error as NSError).userInfo[WordPressComOAuthClient.WordPressComOAuthErrorNewNonceKey] as? String { | ||
| loginFields.nonceInfo?.updateNonce(with: newNonce) | ||
| } | ||
| displayError(message: NSLocalizedString("Whoops, that's not a valid two-factor verification code. Double-check your code and try again!", |
There was a problem hiding this comment.
Maybe we could define the error string in a let before the if block to avoid some duplication?
| static let lastUsedPlaceholder = "last_used_placeholder" | ||
| } | ||
|
|
||
| private enum AuthTypeLengths { |
There was a problem hiding this comment.
For extra clarity it might be nice to add a comment explaining these match the server-side constants.
|
Looks like hiding the sms button changes the next button's layout. |
|
I looked at that button dozens of times and didn't notice that haha. |
|
Ok, @aerych ready for round 2! |
|
@aerych missed the commit for the new comment. Added! |
|
Awesome! |
once BB is green!
|
Thanks @aerych! |
2 participants
Refs #7675
This covers the scenario in which the user's account is already associated with Google, and their WordPress.com account requires 2FA.
To test:
Needs review: @aerych