Feature/7675 social login analytics - #8028
Merged
Merged
Conversation
nheagy
approved these changes
Oct 23, 2017
nheagy
left a comment
nheagy
left a comment
Contributor
There was a problem hiding this comment.
Looks good, depending on your answer to my question about tracking failures by dismissing Google.
if that's as intended
| if let err = error { | ||
| WPAppAnalytics.track(.loginSocialButtonFailure, error: err) | ||
| } else { | ||
| WPAppAnalytics.track(.loginSocialButtonFailure) |
Contributor
There was a problem hiding this comment.
This will track a failure by dismissing either the permission alert or Google login screens. Is that intentional?
Contributor
Author
There was a problem hiding this comment.
It is. The documentation of the corresponding event on the web mentions that it tracks just dismissing the popup modal. I wired it this way for consistency.
ITsonlyme2
approved these changes
Oct 23, 2017
Contributor
Author
|
Thanks Nate! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #7675
Adds social login analytics. These are the same as Calypso except for the following:
To test:
Test social login.
Ensure that each analytic is being bumped as intended.
Needs review: @nheagy