This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Relax WordPressKit dependency from ~> 9.0.0 to ~> 9.0 - #824
Merged
Conversation
A dependency on `~> 9.0.0` results in only versions `9.0.x` being compatible. Under the assumption WordPressKit always respects semantic versioning, that approach limits the versions WordPressAuthenticator can be compatible with. In particular, prevents seamlessly using something like WordPressKit 9.1.0 in a client of both WordPressAuthenticator and WordPressKit. Case in point, I just created WordPressKit 9.0.3, wordpress-mobile/WordPressKit-iOS#677, in place of 9.1.0 in order to avoid having to ship a new WordPressAuthenticator version in the middle of a release cycle.
crazytonyli
approved these changes
Jan 10, 2024
crazytonyli
left a comment
crazytonyli
left a comment
Contributor
There was a problem hiding this comment.
Good call! It should have been 9.0 in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dependency on
~> 9.0.0results in only versions9.0.xbeing compatible. Under the assumption WordPressKit always respects semantic versioning, that approach limits the versions WordPressAuthenticator can be compatible with. In particular, prevents seamlessly using something like WordPressKit 9.1.0 in a client of both WordPressAuthenticator and WordPressKit.Case in point, I just created WordPressKit 9.0.3,
wordpress-mobile/WordPressKit-iOS#677, in place of 9.1.0 in order to avoid having to ship a new WordPressAuthenticator version in the middle of a release cycle.
CHANGELOG.mdif necessary.