Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

fix parsing stats data for empty data sets - #138

Merged
jklausa merged 2 commits into
developfrom
feature/fix-parsing-for-empty-data-sets
Mar 28, 2019
Merged

fix parsing stats data for empty data sets#138
jklausa merged 2 commits into
developfrom
feature/fix-parsing-for-empty-data-sets

Conversation

@jklausa

@jklausa jklausa commented Mar 28, 2019

Copy link
Copy Markdown
Contributor

During testing the new API in WPiOS (wordpress-mobile/WordPress-iOS#11342 ), we found situation where parsing failed for some types where it shouldn't and didn't before. This makes the code somewhat uglier, but c'est la vie ¯_(ツ)_/¯

(I included this branch in the above PR, but just realised I forgot to open a WPKit PR until now. Sorry!)

@jklausa jklausa self-assigned this Mar 28, 2019
@jklausa
jklausa requested a review from ScoutHarris March 28, 2019 20:57

@ScoutHarris ScoutHarris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: !

@jklausa
jklausa merged commit 0fce69e into develop Mar 28, 2019
@jklausa
jklausa deleted the feature/fix-parsing-for-empty-data-sets branch March 28, 2019 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants