This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Fix date component timezone in blogging prompts unit test - #505
Merged
Conversation
dvdchr
enabled auto-merge
May 13, 2022 20:03
ScoutHarris
approved these changes
May 13, 2022
ScoutHarris
left a comment
Contributor
There was a problem hiding this comment.
✅ run the unit tests and ensure that they pass
![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs wordpress-mobile/WordPress-iOS#18607 (review)
Description
Fixes an issue where unit tests for Blogging Prompts could fail locally depending on the system's timezone.
Testing Details
If your timezone is behind UTC, simply run the unit tests and ensure that they pass. Especially this test case:
BloggingPromptsServiceRemoteTests#test_fetchPrompts_returnsRemotePrompts.Otherwise, you can set a temporary timezone modification in
setUpandtearDownlike so:// BloggingPromptsServiceRemoteTests.swift override func setUp() { super.setUp() NSTimeZone.default = TimeZone(secondsFromGMT: -2 * 3600)! // Set timezone to UTC-2. // ... } override func tearDown() { super.tearDown() // ... NSTimeZone.default = NSTimeZone.system // Reset the timezone. }versionin the.podspecfile.