This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Make the deviceId argument optional in the DashboardServiceRemote.deviceId method - #676
Merged
Merged
Conversation
Contributor
Author
salimbraksa
changed the title
salimbraksa
changed the title
mokagio
approved these changes
Jan 9, 2024
mokagio
left a comment
mokagio
left a comment
Contributor
There was a problem hiding this comment.
Thank you @salimbraksa !
Comment on lines
+39
to
+42
| let featureFlagParams: [String: AnyObject]? = try { | ||
| guard let deviceId else { | ||
| return nil | ||
| } |
Contributor
There was a problem hiding this comment.
Oh, interesting. I didn't realize it would be possible to handle a missing deviceId in this way. Looks like a nice way to keep the app "working".
4 tasks
crazytonyli
added a commit
that referenced
this pull request
Jan 11, 2024
The parameter was [initially designed to be non-optional][PR-1]. Later it's later [changed to be optional][PR-2], under [this proposal][comment-1]. This commit simply reverts the parameter to be non-optional, to ship it along with other breaking changes. [PR-1]: #674 [PR-2]: #676 [comment-1]: wordpress-mobile/WordPress-iOS#22320 (comment)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref wordpress-mobile/WordPress-iOS#22320 (comment)
This PR updates the
DashboardServiceRemote.deviceIdmethod to make thedeviceIdargument optional to prevent breaking users of this library.Testing Details
N/A
CHANGELOG.mdif necessary.