Skip to content

[CI] Trigger CI on external PR #420#421

Closed
AliSoftware wants to merge 3 commits into
trunkfrom
trigger-ci-external-pr/420
Closed

[CI] Trigger CI on external PR #420#421
AliSoftware wants to merge 3 commits into
trunkfrom
trigger-ci-external-pr/420

Conversation

@AliSoftware
Copy link
Copy Markdown
Contributor

@AliSoftware AliSoftware commented Oct 20, 2022

Warning: This PR should NOT be merged.

This PR is only there to allow us to trigger the CI on #420 — since CI does not run on PRs involving forks (for security reasons).
This PR is thus not intended to be merged, and #420 will remain the PR on which all review and discussions will happen.

…_client

The use of the github_token under the hood was causing visibility problems about the token being mandatory and necessary to execute some actions on the API
At the moment of the release creation, the githubtoken can be passed as a parameter. In the cases that the param is nil or empty, we fallback to using the github_token from the runtime environment.
At the calling of the action the client has the possibility to use the githubtoken inside the create_relese action, the use is also documented in the ConfigItens
@AliSoftware AliSoftware self-assigned this Oct 20, 2022
@AliSoftware AliSoftware added the Do Not Merge e.g. if it depends on another PR to be merged first, or if that PR is only to trigger CI on forks, … label Oct 20, 2022
@AliSoftware AliSoftware force-pushed the trigger-ci-external-pr/420 branch from a411015 to 4a8d792 Compare October 20, 2022 15:21
@wpmobilebot
Copy link
Copy Markdown

1 Warning
⚠️ Please add an entry in the CHANGELOG.md file to describe the changes made by this PR

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge e.g. if it depends on another PR to be merged first, or if that PR is only to trigger CI on forks, …

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants