Add forceRefresh option to getAccessToken method#85
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a forceRefresh option to the getAccessToken method so callers can always force a token refresh, and includes a test case to validate that behavior.
- Extend
getAccessTokensignature to accept an options object withforceRefresh - Update refresh logic to respect
forceRefresh - Add a test in
create-client.test.tsto verify forced refresh yields a new token
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/create-client.ts | Changed getAccessToken() to getAccessToken(options?: { forceRefresh?: boolean }) and updated refresh condition |
| src/create-client.test.ts | Added a new test verifying that forceRefresh: true always refreshes the access token |
cmatheson
approved these changes
May 20, 2025
This was referenced May 20, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to allow forced refresh of access tokens in the
Clientclass and adds corresponding test coverage. The most important changes include updating thegetAccessTokenmethod to support aforceRefreshoption and adding a test case to verify this behavior.New Feature: Forced Refresh of Access Tokens
src/create-client.ts: Updated thegetAccessTokenmethod in theClientclass to accept an optionalforceRefreshparameter. WhenforceRefreshis true, the access token is refreshed regardless of its expiration status.Test Coverage
src/create-client.test.ts: Added a new test case to ensure thegetAccessTokenmethod correctly refreshes the access token whenforceRefreshis set to true. The test verifies that the refreshed token has the expected claims.