Stop pinning HMM route decisions#677
Merged
Merged
Conversation
…view)
The cost-gate's 'upgrade to a pricier model' gate was hardcoded as
internal/proxy/turnloop.go: const 0.85. Pulled it out as a Service field
with default 0.85 and added WithHMMUpgradeConfidenceThreshold setter;
main.go wires ROUTER_HMM_UPGRADE_CONFIDENCE_THRESHOLD. Out-of-range values
(< 0 or > 1) are rejected and the existing threshold stays.
Three tests in turnloop_internal_test.go:
- TestService_NewService_HMMUpgradeConfidenceDefaults locks the default
- TestService_WithHMMUpgradeConfidenceThreshold covers in-range, double
out-of-range cases, and zero
- TestHMMCostGate_UpgradeThresholdConfigurable exercises a
lower-than-default threshold through the cost gate end-to-end
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Cursor Bugbot findings: - hmmStayPin now ignores a non-HMM (cluster/planner) active pin so a stale pin from a prior strategy can't steer an HMM turn's EV stay; only hmm_history / hmm_policy* reasoned pins are stay candidates. - HMM history maxed-out exclusion no longer gated on PinnedUntil, matching the active-pin path — a saturated model stays excluded after the row's TTL lapses so the auto-continue loop can't re-select it. - recordHMMTurnHistory skips the UpdateUsage writebacks on all-zero usage (failed/empty turn) so a failure can't clobber prior token counts and last_turn_ended_at; the TTL-refreshing upsert still runs. workweave-bot comment-length nits: shortened field/godoc/inline/test comments. Tests: added coverage for the non-HMM-pin gate (ignore + honor), the zero-usage history guard, and the expired-maxed-history exclusion. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Trim the three comments added in the previous review-fix commit to 2 lines each (zero-usage guard, maxed-history no-expiry-gate, non-HMM-pin gate). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ssion-pinning # Conflicts: # internal/proxy/service.go # internal/proxy/service_session_pin_test.go # internal/proxy/turnloop.go # internal/proxy/turnloop_internal_test.go # internal/proxy/turnloop_test.go
|
Claude finished @Symbiomancer's task —— View job Posted one comment-length advisory review on |
workweave-bot
left a comment
workweave-bot
left a comment
Collaborator
There was a problem hiding this comment.
Advisory only — comment-length nits. Won't block merge.
workweave-bot
left a comment
workweave-bot
left a comment
Collaborator
There was a problem hiding this comment.
Advisory only — comment-length nits. Won't block merge.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 55aa45b. Configure here.
 T-Rex LogsWhat T-Rex did
Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Claude finished @Symbiomancer's task —— View job
Posted one review with two comment-length nits on:
|
workweave-bot
left a comment
workweave-bot
left a comment
Collaborator
There was a problem hiding this comment.
Advisory only — comment-length nits. Won't block merge.
6 tasks
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops HMM route decisions from writing active session pins while preserving HMM history, switch tracking, and configurable upgrade-confidence gating.