fix(proxy): serialize LRU check-then-create in no-progress and compaction trackers#736
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
fix(proxy): serialize LRU check-then-create in no-progress and compaction trackers#736devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…tion trackers Adapted from #472 by @rohith500 Co-Authored-By: Steven Tohme <steven@workweave.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
PR author is not in the allowed authors list. |
Co-authored-by: Rohith Reddy Nama <104615697+rohith500@users.noreply.github.com> Co-Authored-By: Steven Tohme <steven@workweave.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noProgressTracker.recordAndDetectandcompactionTracker.checkAndRecordeach do a two-step Get+Add on their LRU. The LRU synchronizes individual calls but not the pair, so racing goroutines could orphan a freshly createdfingerprintRing(losing recorded fingerprints and delaying loop detection) or evaluate the compaction drop check against stale prior state (false-positive detection). Both trackers now hold async.Mutexacross just the Get+Add;ring.recordAndDetectruns outside the lock sincefingerprintRingguards its own state.Adapted from #472 by @rohith500; comments condensed per repo conventions.
Link to Devin session: https://app.devin.ai/sessions/840868be330a4e258f7325867c84caaf
Requested by: @steventohme