Path errors when running `wp dist-archive` on Windows

[VoHoTv]

Hi there! When running the wp dist-archive command I am getting the following erorr:

"Target directory does not exist: C:\Users\USER\Local Sites\het-lokaal\app\public\wp-content\themes\lokaal/C:\Users\USER\Local Sites\het-lokaal\app\public\wp-content\themes\lokaal/C:\Users\USER\Local Sites\het-lokaal\app\public\wp-content\themes"

Is this some kind of misconfiguration on my system? Or am I missing some parameter? Thank you so much!

[danielbachhuber]

Thanks for the report, @VoHoTv !

Is this some kind of misconfiguration on my system? Or am I missing some parameter? Thank you so much!

There are a lot of hardcoded / references in wp dist-archive 🙈

dist-archive-command/src/Dist_Archive_Command.php

Lines 86 to 97 in 8fb85d0

	if ( 0 !== strpos( $path, '/' ) ) {
	$archive_path = dirname( getcwd() . '/' . $path );
	} else {
	$archive_path = dirname( $path );
	}
	$archive_filename = null;
	}
	// If the path is not absolute, it is relative.
	if ( 0 !== strpos( $archive_path, '/' ) ) {
	$archive_path = rtrim( getcwd() . '/' . ltrim( $archive_path, '/' ), '/' );
	}

I think the path breaking is building on Windows.

Maybe it's as simple as replacing the '/' references with DIRECTORY_SEPARATOR ?

Feel free to submit a pull request, if you'd like. Here is some guidance on our pull request best practices.

[costdev]

Looks like there's a couple of things going on here:

1. It's trying to detect / when the separator could be \.
2. It assumes the only absolute path is one beginning with a separator, which would be true for *nix/Windows Network Shares. However, on local Windows paths is DRIVE_LETTER:\...

Take a look at what wp_normalize_path() and path_is_absolute() do. WordPress Core commonly uses these in similar scenarios.

[VoHoTv]

@costdev Just did some tests and when I replace the current conditions which check if it's an absolute path:

"if ( 0 !== strpos( $path, '/' ) ) {}" and "if ( 0 !== strpos( $archive_path, '/' ) ) {}"

And replace it with a copy of the 2 functions you mentioned it works indeed.

[shamimipt]

Hi There, I am fetching the same issue. Is it fixed or Not?

[danielbachhuber]

@shamimipt It's not fixed, no. Feel free to submit a pull request, if you'd like. Here is some guidance on our pull request best practices.

I think we'll also want to get tests running on Windows wp-cli/wp-cli-tests#155

[danielbachhuber]

@VoHoTv @shamimipt Can you install the wp dist-archive main branch and see if #81 resolves your issue on Windows?

[shamimipt]

@VoHoTv Thank you so much.