Skip to content

Implement CS checking based on the WP_CLI_CS ruleset#39

Merged
schlessera merged 2 commits into
wp-cli:masterfrom
sagarnasit:implement-wpcs-ruleset
Jul 23, 2019
Merged

Implement CS checking based on the WP_CLI_CS ruleset#39
schlessera merged 2 commits into
wp-cli:masterfrom
sagarnasit:implement-wpcs-ruleset

Conversation

@sagarnasit
Copy link
Copy Markdown
Contributor

Add a PHPCS ruleset using the new WP_CLI_CS standard.

Fixes #38

related wp-cli/wp-cli#5179

@sagarnasit sagarnasit requested a review from a team as a code owner May 22, 2019 12:13
@sagarnasit
Copy link
Copy Markdown
Contributor Author

This repo does not contain .distignore. should I add it in this PR or do it via separate issue?

@swissspidy
Copy link
Copy Markdown
Member

@sagarnasit Thanks for your contribution! 🎉

Note that a .distignore ignore file is not needed here. That file is only really useful for plugins and themes, not WP-CLI commands like this one.

@schlessera schlessera added command:dist-archive Related to 'dist-archive' command scope:testing Related to testing labels Jul 23, 2019
@schlessera schlessera added this to the 2.0.1 milestone Jul 23, 2019
@schlessera schlessera merged commit 2c8e66a into wp-cli:master Jul 23, 2019
schlessera added a commit that referenced this pull request Mar 11, 2022
Implement CS checking based on the `WP_CLI_CS` ruleset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:dist-archive Related to 'dist-archive' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt and enforce new WP_CLI_CS standard

3 participants