[wpimath] Implement Translation3d.RotateAround#7661
Merged
PeterJohnson merged 4 commits intowpilibsuite:mainfrom Jan 10, 2025
Merged
[wpimath] Implement Translation3d.RotateAround#7661PeterJohnson merged 4 commits intowpilibsuite:mainfrom
PeterJohnson merged 4 commits intowpilibsuite:mainfrom
Conversation
HarryXChen3
commented
Jan 8, 2025
Contributor
Author
|
Also added a test for Translation2d.RotateAround since I noticed it didn't seem to have one |
HarryXChen3
commented
Jan 8, 2025
HarryXChen3
force-pushed
the
translation3d-rotatearound
branch
from
a680e6a to
feb82d5
Compare
KangarooKoala
approved these changes
Jan 9, 2025
Contributor
KangarooKoala
left a comment
KangarooKoala
left a comment
There was a problem hiding this comment.
Looks good to me, for what it's worth. You'll need approval from someone else who's actually on the wpilibsuite team.
calcmogul
approved these changes
Jan 9, 2025
Contributor
Author
|
Looks like tests failed on InterruptTest.RisingEdge, I assume that has nothing to do with my changes? Is it just a flaky test? |
Member
|
Just a flaky test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7658